- Issue created by @catch
- Status changed to Needs review
about 2 months ago 8:53am 23 July 2024 - 🇬🇧United Kingdom catch
Local ddev timings. Down from nearly 9 minutes to 1m43. On gitlab it currently finishes after about 4m10s so would expect it to finish in somewhere around 1 minute give or take.
Before:
../vendor/bin/phpunit profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php PHPUnit 10.5.26 by Sebastian Bergmann and contributors. Runtime: PHP 8.3.8 Configuration: /var/www/html/core/phpunit.xml ... 3 / 3 (100%) Time: 08:55.340, Memory: 6.00 MB
After:
../vendor/bin/phpunit profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php PHPUnit 10.5.26 by Sebastian Bergmann and contributors. Runtime: PHP 8.3.8 Configuration: /var/www/html/core/phpunit.xml . 1 / 1 (100%) Time: 01:43.987, Memory: 6.00 MB
- Status changed to RTBC
about 2 months ago 2:24pm 23 July 2024 - 🇺🇸United States smustgrave
Oh nice, I like tests like this that call the functions. Wonder if we could make that more standard?
Change here looks good though, no loss of coverage.
-
longwave →
committed 816ac01b on 10.3.x
Issue #3463288 by catch: Consolidate test methods in...
-
longwave →
committed 816ac01b on 10.3.x
-
longwave →
committed 12448d24 on 10.4.x
Issue #3463288 by catch: Consolidate test methods in...
-
longwave →
committed 12448d24 on 10.4.x
- 🇬🇧United Kingdom longwave UK
Makes sense to me, as long as it doesn't affect the timings why reinstall over and over. Backported down to 10.3.x as a test-only change.
Committed and pushed 24b7c3ffa3 to 11.x and 64e80c8d84 to 11.0.x and 12448d24bc to 10.4.x and 816ac01be9 to 10.3.x. Thanks!
-
longwave →
committed 64e80c8d on 11.0.x
Issue #3463288 by catch: Consolidate test methods in...
-
longwave →
committed 64e80c8d on 11.0.x
- Status changed to Fixed
about 2 months ago 3:54pm 23 July 2024 -
longwave →
committed 24b7c3ff on 11.x
Issue #3463288 by catch: Consolidate test methods in...
-
longwave →
committed 24b7c3ff on 11.x
- 🇺🇸United States smustgrave
Can I ask a good rule of thumb on when this would be preferred
- 🇬🇧United Kingdom longwave UK
I don't think there is one, it's kinda case by case - it's suitable when the individual tests don't do much work but also we must ensure that combining them doesn't cause side effects where data from an earlier test leaks into a later one.
- 🇬🇧United Kingdom catch
An example of it not working is in 📌 Consolidate Umami performance tests Fixed which I am currrently struggling with. Passes locally but fails with what looks like a race condition in the chrome driver on gitlab.
Automatically closed - issue fixed for 2 weeks with no activity.