Default date ical icon is opinionated

Created on 22 July 2024, 4 months ago

Updated 23 July 2024, 4 months ago

Problem/Motivation

Hi,

Happy to see an ical module maintained, Ical may be a good feature on one of my side projects and I was waiting for a maintained module to add the feature. So, I am currently testing it.

Currently templates/date-ical-icon.html.twig:

<a href="{{ url }}"{{ attributes.addClass('icon-link icon-link-hover') }}>
  <i class="bi bi-calendar-week"></i> {{ title }}
</a>

Is using Bootstrap classes
is using Bootstrap icon, which does not work if the Bootstrap Icons CSS is not present.

Proposed resolution

Remove all Bootstrap related stuff, keep default implementation minimal.

Remaining tasks

Agree on a solution.

User interface changes

🐛 Bug report

Status

Closed: works as designed

Version

4.0

Component

User interface

Created by

🇫🇷France Grimreaper France 🇫🇷

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @Grimreaper
Status changed to Closed: works as designed 4 months ago8:40pm 22 July 2024
Comment 4 months ago →
🇫🇷France lazzyvn paris
Support bootstrap 5 icon by default. If you want to change, you can override twig with your custom theme what ever you want.
You can use Bootstrap 5 admin theme → or module Menu bootstrap icons →
Comment 4 months ago →
🇫🇷France Grimreaper France 🇫🇷
Hi,

If you want to change, you can override twig with your custom theme what ever you want.

Yep, I know that and don't worry that's the first thing I did.

Thanks for the theme and modules suggestion but I prefer UI Suite Bootstrap → and its ecosystem.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024