- Issue created by @pdureau
- 🇫🇷France pdureau Paris
Thursday 25th, we decided during the weekly meeting that only fixes outside the tests/ folder will be done. Inside the
tests/
folder, we will do some annotation skips instead.So, the expected scope is way smaller
PHPMD
Only one fix to do:
- TwigValidatorRuleTest::processNode(): Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
PHPCS
Only 5 fixes to do (or skips to confirm):
- src/Plugin/TwigValidatorRule/TwigValidatorRuleFilter.php: // @phpcs:disable Drupal.Semantics.FunctionT.NotLiteralString
- src/Plugin/TwigValidatorRule/TwigValidatorRuleTest.php: // @phpcs:disable
- src/ValidatorMessage.php: // phpcs:disable Drupal.Semantics.FunctionT.NotLiteralString
- src/ValidatorMessage.php: // phpcs:disable Drupal.Semantics.FunctionT.NotLiteralString
- src/ValidatorMessage.php: // phpcs:disable Drupal.Semantics.FunctionT.NotLiteralString
- Assigned to just_like_good_vibes
- 🇫🇷France pdureau Paris
Mikael, can you also activate the merge block is CI checks are KO?
- First commit to issue fork.
- Merge request !173Resolve #3463153 "2.0.0 beta1 uipatternsdevel code" → (Merged) created by just_like_good_vibes
-
just_like_good_vibes →
committed 723349a8 on 2.0.x
Issue #3463153 by just_like_good_vibes: ui_patterns_devel: code quality
-
just_like_good_vibes →
committed 723349a8 on 2.0.x
- Issue was unassigned.
- Status changed to Fixed
about 1 month ago 10:27pm 5 August 2024 - Status changed to Fixed
26 days ago 2:47pm 12 August 2024