views_access check is broken

Can you check the setting if you're skipping default.

What do you mean? The setting is already checked here and the display will not be added to $sandbox['findings'] if the default is skipped.

There’s a setting form for ignoring default

Yes and $ignore_default contains the value from this setting and is then used in the loop to ignore the default display.
This logic is already there and I have not changed it at all. What are you asking me to do exactly?

Just making sure you had the setting checked in the form

Oh OK. No I don't have this option checked. We do want to check the default display.

I also tried with a non-default display to be sure and I still can reproduce the bug (and the patch fixes it).

So I tested by enabling the show default view setting
Edited the admin content default view to be unrestricted
Ran the check
It captured the finds as expected.

Is the content view the latest enabled view of the first batch of 5 by any chance?
foreach ($views as $view) { will loop on a batch of 5 views and only keep the findings of the latest in this batch. It will then loop on another batch and keep the latest findings in this batch, etc.

So you can by chance avoid the bug if your view is at the end of a batch.
A way to reproduce this is to unprotect the default display of 4-5 views and run the check: it will only display an error for some of the views.

smustgrave → closed merge request !75

That was it.

Automatically closed - issue fixed for 2 weeks with no activity.