- Issue created by @tedbow
- Status changed to Needs work
4 months ago 4:52pm 20 July 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
I specifically opted to chase it because otherwise we get the feedback/complaint that weβre trailing HEAD too far.
But I agree that 2 breaks in 1 week is too much.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
(Too bad that core doesnβt batch these β thatβd have made it much more bearable.)
- Status changed to Active
4 months ago 12:10pm 22 July 2024 - πΊπΈUnited States tedbow Ithaca, NY, USA
I specifically opted to chase it because otherwise we get the feedback/complaint that weβre trailing HEAD too far.
Are we going to be in core anytime soon? I am unsure why it matters if we are month or 2 behind. does this really change that much?
Since I doubt anything will get into core before the demo in Barcelona it seems that we should favor development speed over keeping up with core's phpcs rules.
then? That'd match Drupal 10.x's rules, which won't change as much.
That seems better but π Fix 'Drupal.Commenting.InlineComment.NotCapital' coding standard Fixed was still committed to 10.x branches.
I am going to change the MR to a draft try a couple of ideas. Basically allow us to get a warning if we haven't updated in phpcs rules in X number of days
- Status changed to Needs review
4 months ago 5:23pm 22 July 2024 - πΊπΈUnited States tedbow Ithaca, NY, USA
Think this is ready for review. I used the core/php.xml.dist file before π Fix 'Drupal.Commenting.InlineComment.NotCapital' coding standard Fixed was committed.
You can see the shows a new warning that our
core.phpcs.xml.dist
file is out of date but phpcs job passes. https://git.drupalcode.org/project/experience_builder/-/pipelines/231385I also ran pipeline with were I copied the most recent core/php.xml.dist. This passed the new job to check to see if the phpcs was up to date but failed the phcs job because we are not up to date with all the rules. https://git.drupalcode.org/project/experience_builder/-/pipelines/231381
- πΊπΈUnited States bnjmnm Ann Arbor, MI
Wim Leers β credited bnjmnm β .
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
the new
phpcs-rules-match-drupal-11
jobπ Great call! π
- Status changed to RTBC
4 months ago 11:40am 23 July 2024 - Status changed to Fixed
4 months ago 11:41am 23 July 2024 -
Wim Leers β
committed 0202b5b5 on 0.x authored by
tedbow β
Issue #3462742 by tedbow, Wim Leers, bnjmnm: CI: use a snapshot of core'...
-
Wim Leers β
committed 0202b5b5 on 0.x authored by
tedbow β
Automatically closed - issue fixed for 2 weeks with no activity.