TextFieldMapping.php has CRLF line Terminators

Created on 18 July 2024, 4 months ago

Updated 5 September 2024, 3 months ago

Problem/Motivation

I have a custom patch for WebformContentCreator/FieldMapping/TextFieldMapping.php and I am on a windows WSL system basically linux. I have been struggling to have my patch properly patch using composer cygwin. Finally found out its because this file I guess has Windows line endings.

patching file src/Plugin/WebformContentCreator/FieldMapping/TextFieldMapping.php

Hunk #1 FAILED at 58 (different line endings).

1 out of 1 hunk FAILED -- saving rejects to file src/Plugin/WebformContentCreator/FieldMapping/TextFieldMapping.php.rej

I am able to patch other files in this module just not this specific one. you see this by comparing TextFieldMapping.php to FieldMappingBase.php
/src/Plugin/WebformContentCreator/FieldMapping/TextFieldMapping.php: PHP script, ASCII text, with CRLF line terminators
vs.
/src/Plugin/FieldMappingBase.php: PHP script, ASCII text

Steps to reproduce

Proposed resolution

Remove windows line endings.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Fixed

Version

4.0

Component

Code

Created by

🇺🇸United States NicholasS

Live updates comments and jobs are added and updated live.

Merge Requests

!8TextFieldMapping.php has CRLF line Terminators
Merged
🇺🇸United States NicholasS
updated 3 months ago

Comments & Activities

Issue created by @NicholasS
Merge request !8Fix issues: 3203912 (Empty Datetime fields are inserting current date and... → (Merged) created by NicholasS
Pipeline finished with Success
4 months ago
Total: 134s
#228126
Pipeline finished with Success
4 months ago
Total: 134s
#228128
Comment 4 months ago →
🇺🇸United States NicholasS
Success! I can patch the file again.
Status changed to Needs review 4 months ago5:50pm 18 July 2024
Comment 4 months ago →
🇺🇸United States NicholasS
Status changed to Fixed 3 months ago4:23pm 22 August 2024
Comment 3 months ago →
🇵🇹Portugal joaomarques736
Hello NicholasS,

Thank you for reporting this and for the merge request. It is already merged into 4.x branch and it will go in the next release.

Best regards.
Comment 3 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024