[2.0.0-beta2] External links do not work

Created on 17 July 2024, about 2 months ago
Updated 3 September 2024, 5 days ago

Problem/Motivation

During the conversion the links are turned into

links:
  - 'https://designsystem.digital.gov/components/combo-box/'

But the code in the templates

{% if component.links %}
    <div class="ui_patterns_component__links">
      {% if component.links|length > 1 %}
        {{ "Links:"|t }}
        <ul>
          {% for link in component.links %}
            <li class="ui_patterns_component__link">
              <a href="{{ link.url }}">{{ link.title|default("Documentation") }}</a>
            </li>
          {% endfor %}
        </ul>
      {% else %}
        <p class="ui_patterns_component__link">
          <a class="usa-button" href="{{ links[0].url }}">{{ links[0].title|default("Documentation") }}</a>
        </p>
      {% endif %}
    </div>
  {% endif %}

Expect a url and title key

Steps to reproduce

Proposed resolution

Remove need of url / title key

Or update links conversion.

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Fixed

Version

2.0

Component

UI Patterns Library

Created by

πŸ‡ΊπŸ‡ΈUnited States smustgrave

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024