- Issue created by @mariewakeman
- Assigned to mariewakeman
- πΊπΈUnited States mariewakeman
mariewakeman β changed the visibility of the branch 3462133-accessibility-concerns to hidden.
- πΊπΈUnited States mariewakeman
mariewakeman β changed the visibility of the branch 3462133-accessibility-concerns to active.
- First commit to issue fork.
- πΊπΈUnited States joewhitsitt Iowa
I've been working with mariewakeman off-thread on this and it has turned into a bit of a refactor. To address the accessibility concerns, we started by moving away from the custom js "Add more" inputs and back towards a Form API approach with an AJAX callback. Additionally, the existing JS was not using the Drupal Behaviors attach functionality. The work we have pushed so far is non-functional but is a step forward.
Here is some todo from my perspective:
- Map letter grades to numeric equivalents whether config is supplied or default is used
- Re-wire up response variables to calculation logic and return results to the callback div
- Validate on empty inputs and/or remove empty inputs from the calculation
- Finish removing jQuery and update the library config
- Use Drupal.announce() to notify users of the results
- Since we are bumping to D11, check module for other upgrade issues
- πΊπΈUnited States joewhitsitt Iowa
I think I was able to get it working again, sprinkle in some Drupal.announce and remove the jQuery dependency.
https://git.drupalcode.org/issue/gpa_calculator-3462133/-/compare/2.x......
I think some validation is covered, and it would be nice to confirm the math is right. Interested in input from others.
- First commit to issue fork.
- Status changed to Needs review
about 1 month ago 6:10pm 26 July 2024 - Issue was unassigned.
- Status changed to RTBC
22 days ago 2:33pm 16 August 2024 - πΊπΈUnited States pyrello
This has been tested by multiple members of our team.
-
pyrello β
committed dd50089b on 2.x authored by
mariewakeman β
Issue #3462133 by mariewakeman, pyrello, joewhitsitt: Accessibility...
-
pyrello β
committed dd50089b on 2.x authored by
mariewakeman β
- Status changed to Fixed
22 days ago 2:34pm 16 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.