Accessibility concerns such as missing form and select input labels

mariewakeman → changed the visibility of the branch 3462133-accessibility-concerns to hidden.

mariewakeman → changed the visibility of the branch 3462133-accessibility-concerns to active.

I've been working with mariewakeman off-thread on this and it has turned into a bit of a refactor. To address the accessibility concerns, we started by moving away from the custom js "Add more" inputs and back towards a Form API approach with an AJAX callback. Additionally, the existing JS was not using the Drupal Behaviors attach functionality. The work we have pushed so far is non-functional but is a step forward.

Here is some todo from my perspective:

• Map letter grades to numeric equivalents whether config is supplied or default is used
• Re-wire up response variables to calculation logic and return results to the callback div
• Validate on empty inputs and/or remove empty inputs from the calculation
• Finish removing jQuery and update the library config
• Use Drupal.announce() to notify users of the results
• Since we are bumping to D11, check module for other upgrade issues

I think I was able to get it working again, sprinkle in some Drupal.announce and remove the jQuery dependency.

https://git.drupalcode.org/issue/gpa_calculator-3462133/-/compare/2.x......

I think some validation is covered, and it would be nice to confirm the math is right. Interested in input from others.

This has been tested by multiple members of our team.

Automatically closed - issue fixed for 2 weeks with no activity.