- Issue created by @mrshowerman
- Issue was unassigned.
- Status changed to Needs review
7 months ago 9:06am 17 July 2024 - 🇩🇪Germany hexabinaer Berlin, Germany
I accidentally posted my question in another issue of yours → , so sorry.
Looking into it, the approach makes sense for the
related_date view
.However, I doubt it will work for
oc_map_dates
because as far as I remember this filter would not be reflected in the module's code. Have you really successfully tested that filter in an "OC Map"? - 🇩🇪Germany hexabinaer Berlin, Germany
That's the "Related dates" view. I know the "OC Map" view has its performance issues but that's where our focus currently is. I'd tend to recommend your patch to those interested in this filter option. The OC instances where I have deeper insight all made customizations in one way or the other, especially in exposed filters.
- 🇩🇪Germany mrshowerman Munich
By the time I wrote that comment, the map was indeed based on the OC Map view, but we've changed that in the meantime due to the performance issues.
I've created a new page with the OC Map view: https://beta.kultino.de/node/10386
You will see that the title filter is working, even though the map does not initially show any results (again due to the aforementioned performance issues). - 🇩🇪Germany mrshowerman Munich
Fixed a bug in the "old" map, showing the wrong number of results and wrong pagination when using the new filter: the attachment view display needs to have the same exposed filters as the parent display.
- 🇩🇪Germany hexabinaer Berlin, Germany
The upcoming release contains a basic rework of the OC Map module. I've tested positive adding that filter. We have not added that filter in the default view yet. But assuming that given setups might have made their own customizations we will not update the OC Map views anyway. Feel free to add the event title filter.
After gathering feedback from site-owners we'll add that filter in the default view later.