Contrib.social

Fix Issue when adding form submitting then trying to open results page

Open on Drupal.org →
Created on 17 July 2024, 9 months ago
Updated 20 August 2024, 8 months ago

Problem/Motivation

Issue when adding webform submission then trying to open results page.

Steps to reproduce

1- Add webform or use contact submission
2- Navigate to the webform results page

Proposed resolution

I found that the issue is likly from varbase_layout_builder_entity_operation hook, It adds only entity type id parameter webform submission requires webform parameter, So we need to check if the entity is webform submission and add webform parameter to it.

Remaining tasks

  • ✅ File an issue about this project
  • ❌ Addition/Change/Update/Fix to this project
  • ❌ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Code review from 1 Varbase core team member
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes and Update Helper on new feature change/addition
  • ❌ Release

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • N/A
🐛 Bug report
Status

Active

Version

10.0

Component

Code

Created by

🇯🇴Jordan Ibrahim Tameme

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Ibrahim Tameme
  • Comment 9 months ago →
    🇯🇴Jordan Ibrahim Tameme
  • Status changed to Closed: won't fix 9 months ago
  • Comment 9 months ago →
    🇯🇴Jordan Rajab Natshah Jordan
  • Comment 9 months ago →
    🇯🇴Jordan Rajab Natshah Jordan

    Could be fixed in the same Webform module
    try to update the Webform module first
    They had a new release
    if they did not commit the fix in webform
    we could add a hook to fix this in varbase_webform
    only the location is wrong.

    • try to fix in webform first ( file an issue for them)
    • try to fix this in your custom module ( TEMP ) in the project
    • We can add it in Varbase Webform module
  • Status changed to Active 8 months ago
  • Comment 8 months ago →
    🇯🇴Jordan Rajab Natshah Jordan

    Moved to Varbase Core
    Move the logic to have the fix in Varbase Webform
    Create a new issue fork + a merge request

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024