- Issue created by @mrshowerman
- Issue was unassigned.
- Status changed to Needs review
7 months ago 2:03pm 16 July 2024 - 🇩🇪Germany hexabinaer Berlin, Germany
Looking into it, the approach makes sense for the
related_date
view.However, I doubt it will work for
oc_map_dates
because as far as I remember this filter would not be reflected in the module's code. Have you really successfully tested that filter in an "OC Map"? - 🇩🇪Germany hexabinaer Berlin, Germany
Upon second thought, I might make sense to change the publishing workflow for dates then (default published). As a second step.
- 🇩🇪Germany mrshowerman Munich
Have you really successfully tested that filter in an "OC Map"?
As far as I know, yes. Otherwise the map on https://beta.kultino.de/node/9 would show dozens of "Jever Brauereiführung" dates.
- 🇩🇪Germany moritz.steinhauer Göttingen
We should keep one thing in mind: dates and events might belong to different users. If an ensemble unpublishes an event, all dates (that might be published by locations that host an event) will no longer be visible. But this seems like an edge case to me.
What might be more problematic: often users with the role oc-organiser forget to publish events and only publish their dates. At the moment, this is not a big problem because the text of the event is still rendered in the date, even if the event is unpublished. If we apply mrshowermans patch, we should also change the publishing-workflow for events. Otherwise there will be much more supports-requests caused by "missing dates" in the calendar :-D
- 🇩🇪Germany hexabinaer Berlin, Germany
Good point @moritz.steinhauer. This might be very dependent from how calendar content is created and how site owners set the rules.
It makes sense when events + corresponding dates are imported and published by default. However, we can have different scenarios.
Maybe a more generic solution would rather be found with an optional ECA function and let site-owners decide to unpublish or even delete dates related to the event in question?
- 🇩🇪Germany hexabinaer Berlin, Germany
Oops, so sorry. #3 was related to a different issue :-}