- Issue created by @Kristen Pol
- Assigned to alan.cole
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Assigning to Alan and Feb to work on these.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Add screenshot to summary.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Added note on the name of this in the original Starshot designs:
Note: In the original Starshot design, this section is called "Hero".
- Assigned to Kristen Pol
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Feb did this one with review from Alan. Assigning to myself to review before it's merged.
- Assigned to jacobadeutsch
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Assigning to Jacob to check the variables definition against other components to make sure we are being consistent:
{# /** * @file * Starshot banner component. * * Variables: * - content: [string] Content slot. * - title: [string] Title. * - featured_image: [object] Featured image object: * - url: [string] Source. * - alt: [string] Alt text. * - theme: [string] Theme: light, dark. * - modifier_class: [string] Additional classes. * - attributes: [string] Banner attributes. */ #}
- Status changed to Needs review
8 months ago 10:07pm 5 August 2024 Looks good to me. I know the order doesn't matter but it's pretty common to see the theme as the first variable, but this should work.
- Assigned to Kristen Pol
- Status changed to RTBC
8 months ago 11:59pm 5 August 2024 - πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Thanks. I reordered them and committed the change. Marking for merge.
- Issue was unassigned.
- Status changed to Fixed
8 months ago 5:16pm 9 August 2024 - πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
This was merged so marking fixed.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Not so much a meta issue as work was done here and related work is happening in other metas.
Automatically closed - issue fixed for 2 weeks with no activity.