- Issue created by @dydave
- Merge request !57Issue #3460900 by DYdave: Typed property '' must not be accessed before initialisation. β (Merged) created by dydave
- Status changed to Needs review
8 months ago 9:03pm 11 July 2024 - π«π·France dydave
PHPUnit tests seem to be failing for other reasons...
See failing tests for 4.0.x:
https://git.drupalcode.org/project/s3fs/-/pipelines/220039Let me know if you'd like this particular error to also get added to tests.
Thanks in advance for your feedback and reviews!
-
cmlara β
committed 49485c3e on 4.0.x authored by
DYdave β
Issue #3460900 by DYdave: Typed property must not be accessed before...
-
cmlara β
committed 49485c3e on 4.0.x authored by
DYdave β
- Status changed to Fixed
8 months ago 2:00am 14 July 2024 - πΊπΈUnited States cmlara
Thank you for the MR.
Sorry for the delay, I was debating if we wanted this to be an empty string, or to be NULL.
I was thinking NULL as that was what these used before typedef was added, however an empty string will make long term code usage easier and we have hasValidBucketPlugin() to validate if the plugin is actually valid.
String only with empty default seems perfectly reasonable.
Merging without passing tests as those are held up on multiple D10.3 BC breaks.
- π«π·France dydave
Thanks a lot Conrad (@cmlara) for the prompt feedback, review, merge and additional details!
I'll keep working on more issues and MRs, mostly for D10.3.
Thanks again!
Automatically closed - issue fixed for 2 weeks with no activity.