- Issue created by @kpaxman
- First commit to issue fork.
- π¨π¦Canada ebremner
ebremner β changed the visibility of the branch 3460893-webform-fillpdf to hidden.
- π¨π¦Canada ebremner
ebremner β changed the visibility of the branch 3460893-webform-fillpdf to active.
- Merge request !54Issue #3460893: Update code to allow anon users to download fillable pdfs if... β (Open) created by ebremner
- Status changed to Needs review
6 months ago 9:10pm 4 September 2024 - π¨π¦Canada kpaxman
It's working for me, but it would be nice if someone outside the organization could test. Setting the status to "needs review" in the hopes that happens.
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Hi, Kevin, please rebase on 5.2.x. I don't think there is currently a way to do this. Thanks for the merge request.
- Status changed to Needs work
2 months ago 6:54pm 19 December 2024 - πΊπΈUnited States j-barnes
j-barnes β changed the visibility of the branch 3460893-webform-fillpdf to hidden.
- Merge request !57Issue #3460893: Update code to allow anon users to download fillable pdfs if... β (Open) created by j-barnes
- πΊπΈUnited States j-barnes
Thanks for the feature, this is working great for us! I went ahead and updated / refactored this for the new 5.2.x-dev branch.
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Thanks for the rebase. By the way, you can just force-push to the same branch as the merge request instead of making a new merge request. It will automatically create a tag pointing at the old commits, so there are there to refer to. Nothing is lost.
- πΊπΈUnited States j-barnes
That makes sense to me, I'll do that going forward. I fixed the one issue, but I think the others may be unrelated. See below:
------ -------------------------------------------------------- Line tests/src/Functional/HandlePdfControllerTest.php ------ -------------------------------------------------------- 20 @coversDefaultClass references an invalid class \Drupal\fillpdf\Controller\HandlePdfController Also covers \Drupal\fillpdf\Plugin\FillPdfActionPlugin and \Drupal\fillpdf\OutputHandler.. πͺͺ phpunit.coversClass ------ -------------------------------------------------------- [ERROR] Found 1 error FILE: ...3/web/modules/custom/fillpdf-3460893/tests/src/Traits/TestFillPdfTrait.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 112 | WARNING | [x] Empty PHP statement detected: superfluous semicolon. | | (Generic.CodeAnalysis.EmptyPHPStatement.SemicolonWithoutCodeDetected) --------------------------------------------------------------------------------
- πΊπΈUnited States j-barnes
I've added a new token access test based off the webform populate test. Let me know if you'd like any changes or if you'd prefer some kind of base class added. This should at least get us headed in the right direction.