Single DateTimePicker Range missing dependency on Single DateTimePicker

Created on 11 July 2024, 5 months ago

Updated 12 July 2024, 5 months ago

Problem/Motivation

The Single DateTimePicker Range (single_datetime_range) module depends on the parent module Single DateTimePicker (single_datetime) but that dependency isn't actually configured in the single_datetime_range.info.yml
Therefore it's possible to enable the Single DateTimePicker Range module without enabling the Single DateTimePicker module.
Doing this and trying to access any page will result in the following error:
Error: Class "Drupal\single_datetime\Plugin\Field\FieldWidget\SingleDateTimeBase" not found in include() (line 23 of modules/contrib/single_datetime/modules/single_datetime_range/src/Plugin/Field/FieldWidget/SingleDateTimeRangeWidget.php).

Steps to reproduce

Enable the single_datetime_range module without enabling the single_datetime module.

Proposed resolution

Add the single_datetime module as a dependency of single_datetime_range.

🐛 Bug report

Status

Needs review

Version

2.0

Component

Code

Created by

🇨🇭Switzerland GRcwolf

Live updates comments and jobs are added and updated live.

Merge Requests

!15Single DateTimePicker Range missing dependency on Single DateTimePicker
Open
🇨🇭Switzerland GRcwolf
updated 5 months ago

Comments & Activities

Issue created by @GRcwolf
Merge request !15Issue #3460882: Added single_datetime as a dependency of single_datetime_range → (Open) created by GRcwolf
Pipeline finished with Success
5 months ago
Total: 135s
#222119
Status changed to Needs review 5 months ago7:20pm 11 July 2024
Comment 5 months ago →
🇨🇭Switzerland GRcwolf
I created a simple MR to fix this.
I would appreciate some feedback on it.
Comment 5 months ago →
🇮🇳India Kanchan Bhogade
I've tried to reproduce the issue; unable to see an error message on a page but while module Single DateTimePicker Range installation the Single DateTimePicker module is missing.
MR is applied cleanly...

Test Result:
The Single DateTimePicker Range module depends on the parent module Single DateTimePicker.

Added SS for reference

Keeping in "needs review" for more review and code verification

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024