Wrong homepage link and Deprecated function: substr()

Created on 11 July 2024, 4 months ago

Updated 17 July 2024, 4 months ago

Problem/Motivation

We were getting a 'Deprecated function: substr() Passing null to parameter #1' error and I traced this back to line 65 of the domain_simple_sitemap.module file.
This line makes the assumption that if the domain_config module is installed the front page value can fetched from that config, in our case we had that module installed but the actual front page values are stored in the config for the domain_site_settings.

Steps to reproduce

Install both domain_config and domain_site_settings modules and configure the domain sites using the domain_site_settings config.

Proposed resolution

If domain_config is installed and fetch the config, if that config is empty fetch from domain_site_settings.

🐛 Bug report

Status

Needs review

Version

3.0

Component

Code

Created by

🇬🇧United Kingdom omahm Belfast

Live updates comments and jobs are added and updated live.

Merge Requests

!17Wrong homepage link and Deprecated function: substr()
Open
🇬🇧United Kingdom omahm
updated 4 months ago

Comments & Activities

Issue created by @omahm
Merge request !17Fallback check from when domain_config config does not exist → (Open) created by omahm
Comment 4 months ago →
🇬🇧United Kingdom omahm Belfast
Uploaded patch of changes in fork
First commit to issue fork.
Status changed to Needs review 4 months ago3:11pm 16 July 2024
Comment 4 months ago →
🇧🇪Belgium kevinvb
I had the same issue but with only the patch it didn't work because the value page.front can also be NULL while the configuration exists.
I added an additional check so if the configuration value is empty it doesn't throw the deprecation issue anymore.
Comment 4 months ago →
🇧🇪Belgium kevinvb
Issue was unassigned.
Comment 4 months ago →
🇧🇪Belgium tim-diels Belgium 🇧🇪

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024