- Issue created by @2dareis2do
- ๐ฎ๐ณIndia sarwan
sarwan_verma โ made their first commit to this issueโs fork.
- Status changed to Needs review
about 2 months ago 6:36am 12 July 2024 - ๐ฎ๐ณIndia sarwan
Hi @2dareis2do,
I have created MR!11 for the above issue, Please review it once.
- ๐ฌ๐งUnited Kingdom 2dareis2do
Patch (diff) applies and fixes Warning
Many thanks
- Status changed to RTBC
about 2 months ago 10:22am 12 July 2024 -
gMaximus โ
committed d6f11eb1 on 8.x-1.x authored by
sarwan_verma โ
Issue #3460798 by sarwan_verma, 2dareis2do: userHasSelectedRoles()...
-
gMaximus โ
committed d6f11eb1 on 8.x-1.x authored by
sarwan_verma โ
- Status changed to Fixed
about 2 months ago 7:10pm 17 July 2024 - ๐ฎ๐ณIndia sarwan
hey @gMaximus,
when you move an issue to the "Fixed" state, please remember to give credit to the contributors.
Thankyou !
- ๐ฌ๐งUnited Kingdom gMaximus
Hi @sarwan_verma,
Crediting is something very important to me.
In the commit above, it shows committed by me and authored by you?
Am I missing something? I want it to be right
- ๐ฌ๐งUnited Kingdom gMaximus
My bad. I missed a step. I originally believed that by using the correct commit message, everything else happened.
Thanks for pointing this out. I'll do the same for other fixed issues.
Automatically closed - issue fixed for 2 weeks with no activity.