Fix the issue reported by phpcs

FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/src/Plugin/crossword/crossword_file_parser/CrosswordCompilerXmlParser.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] When importing a class with "use", do not include a leading \ ----------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/src/Plugin/Block/CrosswordInstructionsBlock.php --------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------- 36 | WARNING | [x] A comma should follow the last multiline array item. Found: ] --------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/src/Plugin/Field/FieldType/CrosswordItem.php ----------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. ----------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/src/Plugin/Field/FieldFormatter/CrosswordFormatter.php --------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 3 WARNINGS AFFECTING 7 LINES --------------------------------------------------------------------------------------------------------------------------------- 11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. 232 | WARNING | [ ] Only string literals should be passed to t() where possible 536 | WARNING | [ ] Only string literals should be passed to t() where possible 551 | WARNING | [ ] Only string literals should be passed to t() where possible 610 | ERROR | [x] Use null coalesce operator instead of ternary operator. 616 | ERROR | [x] Use null coalesce operator instead of ternary operator. 782 | ERROR | [x] Expected 1 space before opening brace; found 0 --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/src/Plugin/Validation/Constraint/CrosswordFileValidator.php -------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 5 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\DependencyInjection\ContainerInjectionInterface. 79 | WARNING | [x] The variable name should be defined after the type 82 | WARNING | [ ] Unused variable $data. 85 | ERROR | [ ] The array declaration extends to column 188 (the limit is 120). The array content should be split up over multiple lines 86 | ERROR | [ ] The array declaration extends to column 132 (the limit is 120). The array content should be split up over multiple lines -------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/src/Plugin/Validation/Constraint/CrosswordDimensionsValidator.php ------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------ 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\DependencyInjection\ContainerInjectionInterface. ------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/src/CrosswordFileParserPluginBase.php ----------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Plugin\ContainerFactoryPluginInterface. 43 | WARNING | [ ] File::load calls should be avoided in classes, use dependency injection instead ----------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/src/CrosswordDataService.php -------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------- 75 | ERROR | [x] Use null coalesce operator instead of ternary operator. -------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/crossword.info.yml ------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/crossword.post_update.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 35 | WARNING | Unused variable $field_name. 114 | WARNING | Unused variable $field_formatter_manager. 126 | ERROR | The array declaration extends to column 133 (the limit is 120). The array content should be split up over multiple lines 161 | WARNING | Unused variable $field_formatter_manager. 166 | ERROR | The array declaration extends to column 133 (the limit is 120). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/js/crossword.js ---------------------------------------------------------------------------------------------- FOUND 137 ERRORS AFFECTING 87 LINES ---------------------------------------------------------------------------------------------- 6 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 6 | ERROR | [x] Expected 1 space before opening brace; found 0 35 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 45 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 45 | ERROR | [x] Expected 1 space before opening brace; found 0 46 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 46 | ERROR | [x] Expected 1 space before opening brace; found 0 52 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 55 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 55 | ERROR | [x] Expected 1 space before opening brace; found 0 56 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 56 | ERROR | [x] Expected 1 space before opening brace; found 0 65 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 65 | ERROR | [x] Expected 1 space before opening brace; found 0 66 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 66 | ERROR | [x] Expected 1 space before opening brace; found 0 73 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 79 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 80 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 90 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 108 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 120 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 131 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 137 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 150 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 157 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 157 | ERROR | [x] Expected 1 space before opening brace; found 0 165 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 165 | ERROR | [x] Expected 1 space before opening brace; found 0 177 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 179 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 179 | ERROR | [x] Expected 1 space before opening brace; found 0 186 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 190 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 193 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 203 | ERROR | [x] Case breaking statements must be followed by a single blank line 209 | ERROR | [x] Case breaking statements must be followed by a single blank line 219 | ERROR | [x] Case breaking statements must be followed by a single blank line 229 | ERROR | [x] Case breaking statements must be followed by a single blank line 235 | ERROR | [x] Case breaking statements must be followed by a single blank line 246 | ERROR | [x] Case breaking statements must be followed by a single blank line 252 | ERROR | [x] Case breaking statements must be followed by a single blank line 262 | ERROR | [x] Case breaking statements must be followed by a single blank line 267 | ERROR | [x] Case breaking statements must be followed by a single blank line 274 | ERROR | [x] Case breaking statements must be followed by a single blank line 283 | ERROR | [x] Case breaking statements must be followed by a single blank line 290 | ERROR | [x] Case breaking statements must be followed by a single blank line 298 | ERROR | [x] Case breaking statements must be followed by a single blank line 311 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 311 | ERROR | [x] Expected 1 space before opening brace; found 0 312 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 312 | ERROR | [x] Expected 1 space before opening brace; found 0 324 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 324 | ERROR | [x] Expected 1 space before opening brace; found 0 325 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 325 | ERROR | [x] Expected 1 space before opening brace; found 0 331 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 331 | ERROR | [x] Expected 1 space before opening brace; found 0 332 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 332 | ERROR | [x] Expected 1 space before opening brace; found 0 341 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 341 | ERROR | [x] Expected 1 space before opening brace; found 0 342 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 342 | ERROR | [x] Expected 1 space before opening brace; found 0 349 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 349 | ERROR | [x] Expected 1 space before opening brace; found 0 350 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 350 | ERROR | [x] Expected 1 space before opening brace; found 0 357 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 357 | ERROR | [x] Expected 1 space before opening brace; found 0 358 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 358 | ERROR | [x] Expected 1 space before opening brace; found 0 367 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 367 | ERROR | [x] Expected 1 space before opening brace; found 0 368 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 368 | ERROR | [x] Expected 1 space before opening brace; found 0 381 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 381 | ERROR | [x] Expected 1 space before opening brace; found 0 382 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 382 | ERROR | [x] Expected 1 space before opening brace; found 0 395 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 395 | ERROR | [x] Expected 1 space before opening brace; found 0 396 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 396 | ERROR | [x] Expected 1 space before opening brace; found 0 409 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 409 | ERROR | [x] Expected 1 space before opening brace; found 0 410 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 410 | ERROR | [x] Expected 1 space before opening brace; found 0 422 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 422 | ERROR | [x] Expected 1 space before opening brace; found 0 423 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 423 | ERROR | [x] Expected 1 space before opening brace; found 0 436 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 436 | ERROR | [x] Expected 1 space before opening brace; found 0 437 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 437 | ERROR | [x] Expected 1 space before opening brace; found 0 444 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 444 | ERROR | [x] Expected 1 space before opening brace; found 0 447 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 447 | ERROR | [x] Expected 1 space before opening brace; found 0 450 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 450 | ERROR | [x] Expected 1 space before opening brace; found 0 453 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 453 | ERROR | [x] Expected 1 space before opening brace; found 0 456 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 456 | ERROR | [x] Expected 1 space before opening brace; found 0 459 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 459 | ERROR | [x] Expected 1 space before opening brace; found 0 467 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 467 | ERROR | [x] Expected 1 space before opening brace; found 0 472 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 472 | ERROR | [x] Expected 1 space before opening brace; found 0 477 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 477 | ERROR | [x] Expected 1 space before opening brace; found 0 480 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 480 | ERROR | [x] Expected 1 space before opening brace; found 0 483 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 483 | ERROR | [x] Expected 1 space before opening brace; found 0 487 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 487 | ERROR | [x] Expected 1 space before opening brace; found 0 505 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 505 | ERROR | [x] Expected 1 space before opening brace; found 0 508 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 508 | ERROR | [x] Expected 1 space before opening brace; found 0 513 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 513 | ERROR | [x] Expected 1 space before opening brace; found 0 519 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 519 | ERROR | [x] Expected 1 space before opening brace; found 0 547 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 548 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 552 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 556 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 560 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 565 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 568 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 569 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 571 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found ---------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 137 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/js/classes.js ---------------------------------------------------------------------------------------------- FOUND 107 ERRORS AFFECTING 91 LINES ---------------------------------------------------------------------------------------------- 5 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 15 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 16 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 18 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 19 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 20 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 21 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 23 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 25 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 31 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 36 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 40 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 44 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 45 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 48 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 52 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 56 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 61 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 68 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 70 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 74 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 77 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 80 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 83 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 86 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 89 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 92 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 95 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 98 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 101 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 104 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 108 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 124 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 128 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 133 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 139 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 139 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 140 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 150 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 151 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 152 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 155 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 156 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 170 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 180 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 187 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 198 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 214 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 229 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 244 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 259 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 270 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 305 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 308 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 343 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 346 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 353 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 355 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 356 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 357 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 361 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 398 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 406 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 411 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 411 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 416 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 421 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 421 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 421 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 426 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 427 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 452 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 463 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 465 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 466 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 473 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 484 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 490 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 494 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 495 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 498 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 502 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 517 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 517 | ERROR | [x] Expected 1 space before opening brace; found 0 525 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 525 | ERROR | [x] Expected 1 space before opening brace; found 0 531 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 531 | ERROR | [x] Expected 1 space before opening brace; found 0 535 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 535 | ERROR | [x] Expected 1 space before opening brace; found 0 548 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 548 | ERROR | [x] Expected 1 space before opening brace; found 0 556 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 556 | ERROR | [x] Expected 1 space before opening brace; found 0 562 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 562 | ERROR | [x] Expected 1 space before opening brace; found 0 566 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 566 | ERROR | [x] Expected 1 space before opening brace; found 0 579 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 579 | ERROR | [x] Expected 1 space before opening brace; found 0 634 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 634 | ERROR | [x] Expected 1 space before opening brace; found 0 692 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 692 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 721 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 721 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 727 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" ---------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 107 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_token/crossword_token.tokens.inc ------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------ 40 | WARNING | Unused variable $id. ------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_token/crossword_token.info.yml ---------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ---------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_contest/src/Controller/CrosswordContestController.php --------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES --------------------------------------------------------------------------------------------------------------------------------------- 37 | WARNING | Media::load calls should be avoided in classes, use dependency injection instead 40 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 44 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 64 | WARNING | Media::load calls should be avoided in classes, use dependency injection instead 98 | WARNING | File::load calls should be avoided in classes, use dependency injection instead 100 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead --------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_contest/src/Plugin/Field/FieldFormatter/CrosswordContestFormatter.php ------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------- 71 | WARNING | Unused variable $delta. ------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_contest/README.txt ---------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES ---------------------------------------------------------------------------------------------------- 47 | WARNING | Line exceeds 80 characters; contains 83 characters 54 | WARNING | Line exceeds 80 characters; contains 85 characters 56 | WARNING | Line exceeds 80 characters; contains 81 characters 58 | WARNING | Line exceeds 80 characters; contains 82 characters 60 | WARNING | Line exceeds 80 characters; contains 83 characters 62 | WARNING | Line exceeds 80 characters; contains 82 characters ---------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_contest/crossword_contest.info.yml -------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically -------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_contest/js/crossword-contest.js ----------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found ----------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_image/src/Form/CrosswordImageRegenerateForm.php --------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------------------- 55 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 74 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead --------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_image/src/CrosswordImagePluginBase.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\ImageToolkit\ImageToolkitManager. -------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_image/src/CrosswordImageService.php ---------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------- 11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\File\FileSystem. 64 | ERROR | [ ] Parameter $crossword_data_service is not described in comment ---------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_image/src/Plugin/Field/FieldFormatter/CrosswordImageRendered.php -------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldDefinitionInterface. 12 | WARNING | [x] Unused use statement -------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_image/crossword_image.info.yml ---------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ---------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_pseudofields/src/Form/CrosswordPseudofieldsConfigForm.php ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------- 121 | WARNING | Only string literals should be passed to t() where possible ------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_pseudofields/crossword_pseudofields.info.yml ------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------ 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_status/js/status.js ----------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AFFECTING 4 LINES ----------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 9 | ERROR | [x] Expected 1 space before opening brace; found 0 35 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 35 | ERROR | [x] Expected 1 space before opening brace; found 0 49 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 60 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found ----------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_status/crossword_status.info.yml ------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------ 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_download/src/Plugin/Field/FieldFormatter/CrosswordImageDownload.php ----------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\EntityReferenceFieldItemListInterface. ----------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_download/crossword_download.info.yml ---------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ---------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_colors/src/Form/CrosswordColorsConfigForm.php ------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------------------------------------- 77 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 80 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 81 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 82 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_colors/crossword_colors.info.yml ------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------ 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_media/src/Plugin/media/Source/Crossword.php ----------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\file\FileInterface. ----------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/modules/crossword_media/crossword_media.info.yml ---------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ---------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/tests/src/Kernel/CrosswordFileParserPluginTestBase.php ---------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------- 90 | WARNING | Unused variable $parser. ---------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/tests/src/Kernel/Formatter/CrosswordImageDownloadLinkFormatterTest.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement -------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/tests/src/Kernel/Formatter/CrosswordFileDownloadLinkFormatterTest.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement ------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/tests/src/Functional/CrosswordFieldValidateTest.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 3 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 60 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 67 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 67 | ERROR | The array declaration extends to column 271 (the limit is 120). The array content should be split up over multiple lines 108 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 108 | ERROR | The array declaration extends to column 141 (the limit is 120). The array content should be split up over multiple lines 115 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 115 | ERROR | The array declaration extends to column 143 (the limit is 120). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/tests/src/FunctionalJavascript/CrosswordPseudofieldsTest.php ---------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------- 139 | WARNING | Unused variable $input. ---------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/tests/src/FunctionalJavascript/CrosswordSolutionXssTest.php --------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 39 | WARNING | Unused variable $page. --------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/tests/src/FunctionalJavascript/CrosswordStatusTest.php ---------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------- 46 | WARNING | Unused variable $node_test. 48 | WARNING | Unused variable $node_xss. ---------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/tests/modules/crossword_contest_tests/crossword_contest_tests.info.yml -------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically -------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/tests/modules/crossword_pseudofields_tests/src/Controller/CrosswordTestsController.php ------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 6 WARNINGS AFFECTING 7 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException. 12 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name 29 | WARNING | [ ] Node::load calls should be avoided in classes, use dependency injection instead 32 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 33 | WARNING | [ ] Unused variable $settings. 34 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 37 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/tests/modules/crossword_pseudofields_tests/crossword_pseudofields_tests.info.yml ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------ 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/tests/modules/crossword_tests/src/Controller/CrosswordTestsController.php ------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException. 12 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name 29 | WARNING | [ ] Node::load calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/tests/modules/crossword_tests/crossword_tests.info.yml ---------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ---------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/tests/files/README.txt -------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------- 30 | ERROR | [x] Expected 1 newline at end of file; 2 found -------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/tests/files/3102646.txt --------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES --------------------------------------------------------------------------------------- 1 | WARNING | File encoding is invalid, expected UTF-8 51 | WARNING | Line exceeds 80 characters; contains 154 characters --------------------------------------------------------------------------------------- Time: 4.07 secs; Memory: 22MB

Comments & Activities

Issue created by @bhaveshdas
First commit to issue fork.
Merge request !14Issue #3460754: Fix the issue reported by phpcs → (Open) created by sourav_paul
Pipeline finished with Failed
3 months ago
Total: 300s
#221807
Status changed to Needs work 3 months ago1:29pm 11 July 2024
Comment 3 months ago →
🇺🇸United States danflanagan8 St. Louis, US
Tests are failing. It's pretty obvious why. I'll see if anyone working on this is interested in digging any deeper.
Status changed to Closed: won't fix about 1 month ago9:00pm 27 August 2024
Comment about 1 month ago →
🇺🇸United States danflanagan8 St. Louis, US
The original reporter doesn't seem interested in fixing. Nor am I.

I also want to call out that with

FILE: /var/www/html/drupal-contri-d10/modules/contrib/crossword/tests/files/3102646.txt --------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES --------------------------------------------------------------------------------------- 1 | WARNING | File encoding is invalid, expected UTF-8 51 | WARNING | Line exceeds 80 characters; contains 154 characters
the first warning is actually part of the test! People use non-utf files and that test confirms that the parser works.

And as for a line exceeding 80 characters, in these test files, line breaks mean something important. Splitting a single long clue into multiple lines completely destroys how the puzzle gets parsed.

A lot of the changes are valid, but there's also stuff like calling $this->t() when the class doesn't use the translation trait or whatever, so that function doesn't exist.
Comment 26 days ago →
🇮🇳India sourav_paul Kolkata
Status changed to Needs review 26 days ago9:06am 3 September 2024
Comment 26 days ago →
🇮🇳India sourav_paul Kolkata
@bhaveshdas please review it..
Pipeline finished with Failed
26 days ago
Total: 356s
#272369
Status changed to Closed: won't fix 26 days ago1:05pm 3 September 2024
Comment 26 days ago →
🇺🇸United States danflanagan8 St. Louis, US
Please see #5

Fix the issue reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

Merge Requests

!14Fix the issue reported by phpcs
Open

Comments & Activities

Fix the issue reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

Merge Requests

!14Fix the issue reported by phpcsOpen

Comments & Activities

!14Fix the issue reported by phpcs
Open