Add attribute to form if Gutenberg enabled

Created on 10 July 2024, about 2 months ago
Updated 29 July 2024, about 1 month ago

Problem/Motivation

To make other modules or themes that do form modification aware that the Gutenberg editor is enabled, we should pass that information as an attribute to the form.

My tendency would be a form attribute, but using a data attribute instead of a regular attribute might give the benefit that it's easier addressable also via JS?

Origin: Gin issue at 🐛 Save button missing when using the Gutenberg module and Gin 3.0-rc13 Needs review

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Feature request
Status

Fixed

Version

3.0

Component

Code

Created by

🇩🇪Germany szeidler Berlin

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @szeidler
  • 🇩🇪Germany szeidler Berlin

    @saschaeggi I added an attribute and data attribute at the same time, but generally I would say using the $form['#gutenberg_enabled'] is the proper way for the PHP side of things?

  • Pipeline finished with Canceled
    about 2 months ago
    Total: 313s
    #220728
  • Pipeline finished with Success
    about 2 months ago
    Total: 220s
    #220738
  • 🇨🇭Switzerland saschaeggi Zurich

    @szeidler thanks for the quick turnaround here! I think the PHP attribute is the better solution for sure and works fine for what's needed from Gin's side. The additional data attribute might be beneficial for any JS related checks (if there are any needed).

    Thanks!

  • Status changed to RTBC about 2 months ago
  • 🇨🇭Switzerland saschaeggi Zurich

    Can we get this in soon? Thank you!

  • Pipeline finished with Success
    about 2 months ago
    Total: 230s
    #224513
  • Pipeline finished with Skipped
    about 2 months ago
    #224521
    • szeidler committed 4ec85d25 on 3.0.x
      Issue #3460488 by szeidler, saschaeggi: Add attribute to form if...
  • Pipeline finished with Skipped
    about 2 months ago
    #224524
    • szeidler committed 3b29b3be on 8.x-2.x
      Issue #3460488 by szeidler, saschaeggi: Add attribute to form if...
  • Status changed to Fixed about 2 months ago
  • 🇩🇪Germany szeidler Berlin

    @saschaeggi I merged in the changes. Thanks.

  • Pipeline finished with Success
    about 2 months ago
    Total: 283s
    #226721
  • Pipeline finished with Success
    about 2 months ago
    Total: 258s
    #227573
  • Pipeline finished with Success
    about 2 months ago
    Total: 362s
    #227823
  • Pipeline finished with Success
    about 2 months ago
    Total: 276s
    #227854
  • Pipeline finished with Success
    about 2 months ago
    #229803
  • Pipeline finished with Success
    about 2 months ago
    Total: 321s
    #229814
  • Pipeline finished with Success
    about 1 month ago
    Total: 357s
    #233624
  • Pipeline finished with Success
    about 1 month ago
    Total: 135s
    #234211
  • Pipeline finished with Success
    about 1 month ago
    Total: 134s
    #234212
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Success
    about 1 month ago
    Total: 202s
    #243399
  • Pipeline finished with Success
    about 1 month ago
    #243400
  • Pipeline finished with Success
    about 1 month ago
    #243404
  • Pipeline finished with Failed
    about 1 month ago
    Total: 281s
    #244957
  • Pipeline finished with Failed
    about 1 month ago
    Total: 202s
    #244982
  • Pipeline finished with Success
    about 1 month ago
    Total: 205s
    #245002
  • Pipeline finished with Success
    25 days ago
    Total: 287s
    #253274
  • Pipeline finished with Success
    25 days ago
    Total: 487s
    #253564
  • Pipeline finished with Skipped
    24 days ago
    #254022
  • Pipeline finished with Success
    20 days ago
    Total: 659s
    #257886
  • Pipeline finished with Skipped
    20 days ago
    #257904
  • Pipeline finished with Success
    10 days ago
    Total: 215s
    #267958
  • Pipeline finished with Success
    10 days ago
    Total: 963s
    #267999
  • Pipeline finished with Success
    10 days ago
    Total: 203s
    #268060
  • Pipeline finished with Success
    10 days ago
    Total: 202s
    #268095
  • Pipeline finished with Success
    10 days ago
    Total: 450s
    #268105
  • Pipeline finished with Success
    10 days ago
    Total: 638s
    #268173
  • Pipeline finished with Success
    10 days ago
    #268183
  • Pipeline finished with Success
    10 days ago
    Total: 754s
    #268256
  • Pipeline finished with Canceled
    9 days ago
    Total: 583s
    #269206
  • Pipeline finished with Success
    9 days ago
    Total: 6225s
    #269211
  • Pipeline finished with Success
    9 days ago
    Total: 642s
    #269354
  • Pipeline finished with Success
    9 days ago
    Total: 722s
    #269392
Production build 0.71.5 2024