Contrib.social

Password confirm widget not working with JS validation code

Open on Drupal.org →
Created on 10 July 2024, 9 months ago

Problem/Motivation

We've been using the password confirm widget on some forms* but have seen the validation widget consistently emitting JS errors. The error seems to be due to it using Drupal core's Javascript to run the validation, which expects a specific classname to be on the wrapper element that isn't present.

Uncaught TypeError: $confirmInput[0] is undefined
    passwordCheck http://localhost:8080/core/modules/user/user.js?v=10.2.7:232
    jQuery 8
    attach http://localhost:8080/core/modules/user/user.js?v=10.2.7:250
    attach http://localhost:8080/core/modules/user/user.js?v=10.2.7:66

Referring to https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/user/..., $passwordWidget expects the wrapper to have classname js-form-type-password-confirm. I've seen js-webform-type-password-confirm, but never js-form-type-password-confirm.

Steps to reproduce

  1. Create a webform with the password confirm widget
  2. Load the form in the browser
  3. Enter one character inside the first password field

* We're deliberately not saving submissions to our database, and anyone else using the Password Confirm widget should be taking similar precautions.

Proposed resolution

Add the classname js-form-type-password-confirm to the wrapper element for Password Confirm webform widgets.

Remaining tasks

  1. Add the classname
  2. Test the fix

User interface changes

None.

API changes

None.

Data model changes

None.

🐛 Bug report
Status

Active

Version

6.2

Component

Code

Created by

🇦🇺Australia geoffreyr

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @geoffreyr
  • Merge request !4883460381: Add extra CSS class to ensure password_confirm works with core User JS → (Merged) created by geoffreyr
  • Issue was unassigned.
  • Status changed to Needs review 9 months ago
  • Comment 9 months ago →
    🇦🇺Australia geoffreyr

    MR is in. I should review the existing tests to see if the behaviour is already covered or not.

  • Pipeline finished with Success
    9 months ago
    Total: 3432s
    #220421
  • First commit to issue fork.
  • Comment 4 months ago →
    🇺🇸United States jrockowitz Brooklyn, NY

    Attached webform replicates the issue.

    Let's move the fix into \Drupal\webform\Plugin\WebformElement\PasswordConfirm

  • Pipeline finished with Canceled
    4 months ago
    Total: 74s
    #347564
  • Pipeline finished with Failed
    4 months ago
    Total: 1918s
    #347565
  • Pipeline finished with Success
    4 months ago
    Total: 464s
    #347805
  • Comment 4 months ago →
    🇺🇸United States jrockowitz Brooklyn, NY
  • Pipeline finished with Skipped
    4 months ago
    #351357
  • Pipeline finished with Skipped
    4 months ago
    #351358
  • Comment 4 months ago →
    🇺🇸United States jrockowitz Brooklyn, NY
  • Comment 4 months ago →
    System Message
  • Pipeline finished with Success
    4 months ago
    Total: 781s
    #351356
  • Comment 4 months ago →
    System Message
  • Comment 4 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Success
    4 months ago
    Total: 755s
    #371691
  • Pipeline finished with Success
    4 months ago
    Total: 1648s
    #371705
  • Pipeline finished with Skipped
    4 months ago
    #374006
  • Pipeline finished with Success
    4 months ago
    Total: 687s
    #374000
  • Pipeline finished with Failed
    2 months ago
    Total: 54s
    #414988
  • Pipeline finished with Failed
    2 months ago
    Total: 56s
    #414993
  • Pipeline finished with Failed
    2 months ago
    Total: 54s
    #415001
  • Pipeline finished with Failed
    2 months ago
    Total: 335s
    #415050
  • Pipeline finished with Canceled
    2 months ago
    Total: 214s
    #415057
  • Pipeline finished with Failed
    2 months ago
    Total: 454s
    #415058
  • Pipeline finished with Failed
    2 months ago
    Total: 881s
    #415062
  • Pipeline finished with Failed
    2 months ago
    Total: 432s
    #415077
  • Pipeline finished with Canceled
    2 months ago
    Total: 73s
    #415080
  • Pipeline finished with Failed
    2 months ago
    Total: 691s
    #415081
  • Pipeline finished with Failed
    2 months ago
    Total: 862s
    #415095
  • Pipeline finished with Failed
    2 months ago
    Total: 755s
    #415105
  • Pipeline finished with Success
    2 months ago
    Total: 802s
    #415150
  • Pipeline finished with Failed
    2 months ago
    Total: 470s
    #415167
  • Pipeline finished with Canceled
    2 months ago
    Total: 155s
    #415174
  • Pipeline finished with Canceled
    2 months ago
    Total: 752s
    #415175
  • Pipeline finished with Success
    2 months ago
    Total: 869s
    #415182
  • Pipeline finished with Failed
    2 months ago
    Total: 911s
    #415287
  • Pipeline finished with Failed
    2 months ago
    Total: 336s
    #415299
  • Pipeline finished with Failed
    2 months ago
    Total: 392s
    #415300
  • Pipeline finished with Success
    2 months ago
    Total: 857s
    #415306
  • Pipeline finished with Success
    2 months ago
    Total: 847s
    #415648
  • Pipeline finished with Success
    2 months ago
    Total: 998s
    #415676
  • Pipeline finished with Failed
    2 months ago
    Total: 496s
    #415740
  • Pipeline finished with Success
    2 months ago
    Total: 1376s
    #415748
  • Pipeline finished with Success
    2 months ago
    #415958
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024