Use request_parse_body() in PHP 8.4 and remove special handling of input stream file uploads

Created on 9 July 2024, 5 months ago

Updated 16 December 2024, 2 days ago

Problem/Motivation

PHP 8.4 introduces a request_parse_body() function that reads the php://input stream and populates the $_POST and $_FILES superglobals, such as when you upload files via a form with "multipart/form-data" enctype.

We should see if we can use this and avoid special handling for REST and JSON-API file uploads.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task

Status

Active

Version

11.0 🔥

Component

File module →

Last updated 1 day ago

Maintained by
🇦🇺Australia @kim.pepper

Created by

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Live updates comments and jobs are added and updated live.

PHP 8.4

Comments & Activities

Issue created by @kim.pepper
First commit to issue fork.
Comment 2 days ago →
🇺🇸United States drupalshapoopie
@kim.pepper - can you point me at the special handling we'd like to replace?
Comment 1 day ago →
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
Why sure @drupalshapoopie ! It's these two objects:

https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/file/...

https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/file/...

Plus the logic of checking which type and saving an input stream to file.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024