- Issue created by @catch
- Status changed to Needs review
4 months ago 4:28pm 8 July 2024 - Merge request !6Issue #3460015: change the default classname to be a base36 encoded learning path ID * 100. → (Merged) created by catch
- 🇬🇧United Kingdom catch
Class names look like this:
339 | Class PM8 | | 340 | Class PJG | | 341 | Class P5K | | 342 | Class OX8 | | 343 | Class OOW | | 344 | Class OGK | | 345 | Class NUC | | 346 | Class NRK | | 347 | Class NM0 | | 348 | Class NJ8 | | 349 | Class NGG | | 350 | Class NDO | | 351 | Class NAW | | 352 | Class N84 | | 353 | Class N5C | | 354 | Class N2K | | 355 | Class M2G | | 356 | Class LWW | | 357 | Class L7W | | 358 | Class L2C | | 359 | Class KR8 | | 360 | Class KG4 | | 361 | Class K28 | | 362 | Class JZG | | 363 | Class JWO | | 364 | Class JOC | | 365 | Class JLK | | 366 | Class JIS |
- First commit to issue fork.
- Status changed to Fixed
4 months ago 6:01am 9 July 2024 - 🇵🇱Poland Graber
While porting, got this:
There was 1 error: 1) Drupal\Tests\lms\FunctionalJavascript\GeneralLmsTest::testLms TypeError: base_convert(): Argument #1 ($num) must be of type string, int given /var/www/html/web/modules/contrib/lms/src/Hooks/EntityHooks.php:125 /var/www/html/web/modules/contrib/lms/tests/src/FunctionalJavascript/GeneralLmsTest.php:188 /var/www/html/web/modules/contrib/lms/tests/src/FunctionalJavascript/GeneralLmsTest.php:100
fixed with
'@class_name' => \strtoupper(\base_convert((string) ($course->id() + 100), 10, 36))
- Status changed to Needs work
4 months ago 7:42am 9 July 2024 - Status changed to Fixed
4 months ago 2:17pm 15 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.