- Issue created by @longwave
- Status changed to Needs review
2 months ago 12:38pm 8 July 2024 - Status changed to Needs work
2 months ago 1:11pm 8 July 2024 - 🇬🇧United Kingdom longwave UK
ImageUrlTest has broken, probably due to this minor breaking change from the release notes:
The Insert image via URL UI component form has been moved to a modal dialog instead of being available directly in the insert image dropdown.
- Status changed to Needs review
about 2 months ago 10:47am 10 July 2024 - 🇬🇧United Kingdom longwave UK
Fixed the test to look for the CSS selectors in the dialog instead of the panel.
- Status changed to RTBC
about 2 months ago 11:01am 10 July 2024 - 🇳🇱Netherlands Spokje
Code changes make sense and tests are green => RTBC
- Status changed to Downport
about 2 months ago 11:26am 10 July 2024 - 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 11.0.x, thanks!
We should backport this to 10.4.x but that will require a separate MR since it's not a clean cherry-pick.
- Assigned to Spokje
- 🇳🇱Netherlands Spokje
Lemme have a go at this, as I presume that @longwave is busy enough with more important RC1 stuff (like all other core committers ofc)
- Issue was unassigned.
- Status changed to Needs review
about 2 months ago 12:25pm 10 July 2024 - Status changed to Fixed
about 2 months ago 12:45pm 10 July 2024 - 🇬🇧United Kingdom catch
Same actual code changes as the 11.x MR so going to go ahead here.
Committed/pushed to 10.4.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.