Contrib.social

AdminUiTest::testSettingsPage() Fails to Assert that Fields Exist

Open on Drupal.org →
Created on 8 July 2024, 9 months ago
Updated 13 July 2024, 9 months ago

Problem/Motivation

As is identified in a review of MR5:

Is this supposed to be asserting something? This doesn't actually prove anything, it just returns a boolean. I suspect you want this:

-   $this->page->hasField('rum_instrumentation');
+   $this->assertSession()->fieldExists('rum_instrumentation');

You probably want to change this for the rest of this test, too, in another issue.

This issue is created as a follow-up issue.

Proposed resolution

Update AdminUiTest::testSettingsPage() to assert ->fieldExists().

Remaining tasks

Open MR

User interface changes

None

API changes

None

Data model changes

None

🐛 Bug report
Status

RTBC

Version

2.0

Component

Code

Created by

🇺🇸United States Chris Burge

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024