- Issue created by @renatog
- Merge request !2Issue #3459498 by renatog: Add Optional "Target" for Link, with that editors... → (Merged) created by renatog
- Status changed to Needs review
4 months ago 6:17am 6 July 2024 - 🇧🇷Brazil renatog Campinas
Implemented at: https://git.drupalcode.org/project/ept_tiles/-/merge_requests/2
- 🇧🇷Brazil renatog Campinas
Implemented at: https://git.drupalcode.org/project/ept_tiles/-/merge_requests/2
- Status changed to Needs work
4 months ago 6:07am 8 July 2024 - 🇷🇸Serbia levmyshkin Novi Sad, Serbia
Hi, Renato, thank you for your update! I think we should use checkbox "Open in a new tab" instead of select list for _target attribute. Many people don't know about HTML and they will not use other options for 99% percents of cases. You can see implementation for "Open in a new tab" in EPT Basic Button module:
https://git.drupalcode.org/project/ept_basic_button/-/blob/1.4.x/templat... - Status changed to Needs review
4 months ago 11:38am 9 July 2024 - 🇧🇷Brazil renatog Campinas
- 🇷🇸Serbia levmyshkin Novi Sad, Serbia
Hi Renato, thank you for your update. I'm not sure about using 'per tile' setting for open a new tab. I thought about using one checkbox for entire EPT Tiles which will be applied for all tiles together. I didn't face requirements on my projects to make only one tile opens on a new tab, usually all tiles had the same behavior. Did you make it granulary for tile on purpose?
I suggest to use EptSettingsTilesWidget.php form and add the new field there. You can pass EBT Settings values in hook_preprocess_paragraph(), get parent entity from EPT Tile and save value for Open in a new tab in $variables. What do you think?
- Status changed to Needs work
4 months ago 8:14am 10 July 2024 - Assigned to renatog
- 🇧🇷Brazil renatog Campinas
Hello Ivan
Did you make it granulary for tile on purpose?
Not actually, It was the initial solution on mind, but didn't think about one checkbox per group
I thought about using one checkbox for entire EPT Tiles which will be applied for all tiles together
Agreed. It'll guarantee consistence across all items
I suggest to use EptSettingsTilesWidget.php form and add the new field there. You can pass EBT Settings values in hook_preprocess_paragraph(), get parent entity from EPT Tile and save value for Open in a new tab in $variables. What do you think?
Makes sense for me
I'll update the MR and I'll let you knowI'll update on EPT first, and when is approved I'll replicate on EBT Tiles ✨ Add the target option to open link on new tab/window Needs work
- Issue was unassigned.
- Status changed to Needs review
2 months ago 8:07pm 31 August 2024 - 🇧🇷Brazil renatog Campinas
Hello @levmyshkin , I hope you're well
Sorry by the delay, I've been busy in the last few days
I suggest to use EptSettingsTilesWidget.php form and add the new field there. You can pass EBT Settings values in hook_preprocess_paragraph(), get parent entity from EPT Tile and save value for Open in a new tab in $variables
Implemented suggestion above
MR is available for review: https://git.drupalcode.org/project/ept_tiles/-/merge_requests/2
- 483ce70c committed on 1.4.x
Issue #3459498 by renatog, levmyshkin: Add Optional "Target" for Link,...
- 483ce70c committed on 1.4.x
- 857a8240 committed on 1.4.x
Issue #3459498 by renatog, levmyshkin: Add Optional "Target" for Link,...
- 857a8240 committed on 1.4.x
- eaf217a5 committed on 1.4.x
Issue #3459498 by renatog, levmyshkin: Add Optional "Target" for Link,...
- eaf217a5 committed on 1.4.x
- 7b43d222 committed on 1.4.x
Issue #3459498 by renatog, levmyshkin: Add Optional "Target" for Link,...
- 7b43d222 committed on 1.4.x
- 🇷🇸Serbia levmyshkin Novi Sad, Serbia
Thank you, Renato! I merged your changes.
- Status changed to Fixed
2 months ago 11:47am 2 September 2024