Contrib.social

CKE5 - When setting a default editor content language, and rtl default in config, the first paragraph get's ltr direction

Open on Drupal.org →
Created on 5 July 2024, 10 months ago
Updated 12 July 2024, 10 months ago

Problem/Motivation

When setting a default content language (that uses RTL direction) using the hook hook_editor_js_settings_alter(), for example:

/**
 * Implements hook_editor_js_settings_alter.
 */
function modulename_editor_js_settings_alter(array &$settings) {
  foreach ($settings['editor']['formats'] as $name => $value) {
    $settings['editor']['formats'][$name]['editorSettings']['language'] = [
      'ui' => 'en',
      'content' => 'ar'
    ];
  }
}

Setting the default content language to Arabic.

And, also setting the RTL direction as default in the plugin config

When editing a node (ie: this issue is not present on first node create form), the first paragraph gets a dir="ltr".

A video demonstrating this can be found in 🐛 On node edit, the RTL gets unset only for the first paragraph. Fixed

Steps to reproduce

  1. Add a hook_editor_js_settings_alter setting the editor default content language to Arabic (you can use the code block above as example)
  2. Go to configure the text formats, and check the "Make right to left option default." checkbox
  3. Go create a new node
  4. Check the editor uses RTL as default direction
  5. Type and/or paste some text in the editor
  6. Save the node
  7. Go edit the same node
  8. Note how the first paragraph has now a ltr dir attribute

Proposed resolution

I'm creating a MR that solves this issue under the mentioned conditions:

  • Using the hook_editor_js_settings_alter to set a default content language (Please note this allows RTL languages sites to have all content in ckeditor -not only text- like embeds and such to be RTL)
  • Setting RTL as default direction in the plugin configuration

I tested it also without the hook, and I didn't noted any side effects, but it would probably need more testing.

Remaining tasks

Test in other scenarios?

🐛 Bug report
Status

Closed: duplicate

Version

4.0

Component

Code

Created by

🇦🇷Argentina anairamzap Buenos Aires

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @anairamzap
  • Comment 10 months ago →
    🇦🇷Argentina anairamzap Buenos Aires
  • Merge request !123459354 - Remove init code block → (Open) created by anairamzap
  • Pipeline finished with Failed
    10 months ago
    Total: 154s
    #216957
  • Status changed to Needs review 10 months ago
  • Comment 10 months ago →
    🇦🇷Argentina anairamzap Buenos Aires

    Setting to needs-review since a MR was provided.

    The MR removes the "init" code block, since is checking for the first block direction attribute and when using a default content language no direction is added when the direction matches the default language direction.

    I'm not sure which issues that code block was preventing, so maybe you can try to reproduce those issues without this code.

  • Pipeline finished with Failed
    10 months ago
    Total: 156s
    #216995
  • Status changed to Needs work 10 months ago
  • Comment 10 months ago →
    🇺🇸United States smustgrave

    tested out locally and with the change when I go to create a new node now the RTL setting isn't taking affect.

  • Comment 10 months ago →
    🇦🇷Argentina anairamzap Buenos Aires

    Did you pulled the last commit? I forgot to update the built artifact in the previous one :S

    Also, are you using the hook_editor_js_settings_alter to set the default "ar" language?

  • Status changed to Closed: duplicate 10 months ago
  • Comment 10 months ago →
    🇺🇸United States smustgrave

    lets fix over here.

  • Pipeline finished with Success
    about 9 hours ago
    Total: 279s
    #482194
  • Pipeline finished with Failed
    about 9 hours ago
    Total: 157s
    #482196
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024