Contrib.social

Add Token support for Nominatim provider, and possibly others

Open on Drupal.org →
Created on 5 July 2024, 12 months ago

Problem/Motivation

It would be nice if the values for "User Agent" and "Referer" for the Nominatim provider could be set to some default values, by adding Token support.

This would help the Drupal Starshot project:

@phenaproxima:

User Agent: Value of the User-Agent header, for example "Drupal example.org". Replace "example.org" ...
Referer: Value of the Referer header, for example "https://example.org/". Replace with your URL.

These are problematic for us because, at install time, we don't know what our URL is or will be.
Can these be anything that look like a URL? For example, could I set a value of http://drupal-SOME_UUID.localhost?

@mlncn:

Would it make sense to use tokens in the site-URL-dependent geocoder provider settings? If it does make sense and would solve our problem but it is not yet possible, we could open an issue to add token support?

Comments from the Drupal Starshot issue Use Geofield and Leaflet modules for maps, to respect user privacy #81 .

Steps to reproduce

Proposed resolution

Add Token support for some provider fields, such as "User Agent" and "Referer".

As a start for the Nominatim provider, and later possibly for more providers, or perhaps all of them?

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request
Status

Active

Version

4.0

Component

Code

Created by

🇩🇰Denmark ressa Copenhagen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @ressa
  • First commit to issue fork.
  • Merge request !55Resolve #3459311 "Add token support" → (Open) created by phenaproxima
  • Pipeline finished with Success
    12 months ago
    #216821
  • Pipeline finished with Canceled
    12 months ago
    Total: 155s
    #216826
  • Pipeline finished with Success
    12 months ago
    #216828
  • Pipeline finished with Success
    12 months ago
    Total: 177s
    #216830
  • First commit to issue fork.
  • Comment 16 days ago →
    🇮🇹Italy itamair

    @ressa @phenaproxima is this still valid / valuable for the Drupal CMS?
    I cannot see any reference to this feature request / patch in the Drupal CMS repository,
    and all this looks kind of very specific use case ...
    Thus I am not fully incline to commit this into the Geocoder 8.x-4.x-dev branch.
    But didn't fully investigated this use case, so not 100% sure in either direction.
    Please let me know if this could be closed as Outdated or still moved forward and how ...

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024