Remove deprecated function call _drupal_flush_css_js() and FileSystemInterface::EXISTS_REPLACE in simple_menu_icons.module file

Issue created by @manish-31
Merge request !10Issue #3459278: Fixed deprecated code from simple_menu_icons.module file. → (Open) created by manish-31
Status changed to Needs review 3 months ago12:47pm 5 July 2024
Comment 3 months ago →
🇮🇳India manish-31
MR raised to replace deprecated code, needs review.
Status changed to RTBC about 1 month ago10:17am 16 August 2024
Comment about 1 month ago →
🇮🇳India Tirupati_Singh
Hi @manish-31, I've applied the raised MR !10 as a patch and it applied cleanly with no errors. After applying the patch all the deprecated method calls have been removed as per the Drupal documentation. After applying the patch, the module functionality is working as expected, and there are no errors related to the module functionality.

However, there is an unrelated issue with the menu icon, the uploaded menu icon is not being displayed while using this module in Drupal 10.2 and 10.3 versions. This issue is documented separately at https://www.drupal.org/project/simple_menu_icons/issues/3379128 🐛 Generated CSS file being deleted immediately after being created RTBC . Applying the patch provided in that issue resolves the menu icon problem.

As the provided MR !10 addresses the deprecated functions call issue effectively and has no errors, I am moving the issue status to RTBC.

Tested on Drupal 10.3.2.

Merge Requests