I'm in the process of upgrading to Drupal 10. I am running Drupal 9.5.11, PHP version 8.1.27, and was running magnific popup 1.5.
After upgrading the module to version 2.0.0, I get the following error on node pages view + administrative Manage Display pages that have the magnific popup formatter:
Fatal error: Declaration of Drupal\magnific_popup\Plugin\Field\FieldFormatter\MagnificPopupMedia::viewElements(Drupal\Core\Field\FieldItemListInterface $items, $langcode) must be compatible with Drupal\magnific_popup\Plugin\Field\FieldFormatter\MagnificPopup::viewElements(Drupal\Core\Field\FieldItemListInterface $items, $langcode): array in /var/www/html/web/modules/contrib/magnific_popup/src/Plugin/Field/FieldFormatter/MagnificPopupMedia.php on line 48
Upgrade the module to version 2.0.0 and access view pages that use the formatter oand/or the Manage Display for entities that use the magnific popup.
Make the viewElements method in web/modules/contrib/magnific_popup/src/Plugin/Field/FieldFormatter/MagnificPopupMedia.php match the parent. In this case, the array return is not present in the child class. Or, remove the array return in the parent.
-
-
-
-
Closed: works as designed
2.0
Code
Sorry, forgot I had a patch. Will check for updated version here:
https://www.drupal.org/project/magnific_popup/issues/2849202
✨
Support for media reference fields
Needs review
My bad