- Issue created by @dev2.addweb
- Issue was unassigned.
- Status changed to Needs review
5 months ago 8:00am 3 July 2024 - 🇮🇳India dev2.addweb
Hi,
I have fixed phpcs issues and created MR. Please review it. - 🇮🇳India bhaveshdas
i have tested MR 1 and i have found some error below:-
use below this command-: vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/custom/ckeditor_infocard-3458698/FILE: /var/www/html/drupal-contri-d10/modules/custom/ckeditor_infocard-3458698/css/infocard.frontend.css -------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------- 33 | ERROR | [x] CSS colours must be defined in lowercase; expected #f5f5f5 but found #F5F5F5 -------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------- Time: 1.53 secs; Memory: 12MB
- Status changed to Needs work
4 months ago 6:01am 4 July 2024 - Status changed to Needs review
4 months ago 6:43am 4 July 2024 - 🇮🇳India dev2.addweb
Hi,
I have fixed phpcs issue as mention in #4. Please review it. -
sianto →
committed 5218d231 on 1.0.x authored by
nilesh.addweb →
#3458698 fixed phpcs issues
-
sianto →
committed 5218d231 on 1.0.x authored by
nilesh.addweb →
- Status changed to Fixed
4 months ago 6:46am 5 July 2024 - 🇮🇳India dev2.addweb
@sianto, when you move an issue to the "Fixed" state, please remember to give credit to the contributors.
Automatically closed - issue fixed for 2 weeks with no activity.