- Issue created by @greenskin
- Status changed to Needs review
6 months ago 2:56pm 2 July 2024 - Status changed to Needs work
6 months ago 8:40pm 2 July 2024 - π³π±Netherlands johnv
I tested Gin 8.x-3.0-rc12 (administration theme).
I installed it as default theme, not only as administrative theme.
I tested the following:
- node view mode (with Transition form as formatter): works fine without patch
- node edit view: action buttons are hidden/removed (but patch does not help)
- node workflow history tab: action buttons work fine without patch.
- block with workflow transition form (after adding block to theme layout).So, in my system, all-but the edit mode work fine, but the patch does not help.
Do I need to do anything more? - π³π±Netherlands johnv
OK, I see now, I did not find the 'More actions button.
I guess this title is better. - Status changed to RTBC
6 months ago 11:28am 4 July 2024 - Status changed to Fixed
6 months ago 11:29am 4 July 2024 - πΊπΈUnited States todea
Similar issue, we are using Workflow 8.x-1.7 and Gin 8.x-3.0-rc13. For the nodes where we use workflow, the Save & Delete actions are removed. Save is replaced w/ "Update workflow".
If we switch back to Claro as the admin theme, then save and delete properly display.
- π³π±Netherlands johnv
@todea, I am sorry, where do you see those buttons/tasks?
I cannot find the phrase 'Update workflow' in the repository. Is it the name of a transition label (admin/config/workflow/workflow/workflow1/transition_labels), or are you perhaps using core Workflows (mind the trailing 's') instead of this contrib module? - π³π±Netherlands johnv
@todea, in my case, the buttons 'Save', 'Preview', 'Delete', are replaced by 1 button 'Save'. the Preview and Delete buttons are not visible (there is no 'more actions' dropdown menu). I guess this is not caused by the Workflow module.
- πΊπΈUnited States todea
@johnv, yeah I'm not sure why this is happening. I am using this "workflow" module, version 8.x-1.7. I see a 'Update workflow' button label in
src\Form\WorkflowTransitionForm.php
. This occurs on the add/edit screen for an "event" node on our site. - πΊπΈUnited States todea
It looks like the issue was caused by having the "Workflow transition form" on our form display. When I change that display to check boxes or select list, then the normal node save/delete actions come back.
- πΊπΈUnited States greenskin
Looks like something when building the transition form in WorkflowManager::getWorkflowTransitionForm() is causing the additional actions (e.g., preview, delete, etc) to disappear.
- πΊπΈUnited States greenskin
Dug a little deeper and the issue with the missing actions looks to be with Gin and how it's altering actions for the content form. Gin is effectively setting the actions based on the transition form and not the actual node content form (see GinContentFormHelper::formAlter()). Because the workflow transition form is altered after the node form, the workflow transition actions take precedence for Gin. I'm not sure there's anything specific the workflow module can do here other than work with gin maintainers for a solution.
- π³π±Netherlands johnv
Indeed, GinContentFormHelper::formAlter() is the problem. It assumes that a button 'submit exists', which is not the case with workflow action buttons. Not sure yet why the 'preview' button has gone.
(There is a 'postponed' issue that requests a reshuffle of the action buttons, leaving the submit button untouched (except for the title perhaps). I cannot find is now. ) - Status changed to Needs work
5 months ago 9:13pm 20 July 2024 - π³π±Netherlands johnv
Perhaps we need some modifiction in function _workflow_transition_form_get_action_buttons().
- Status changed to Needs review
5 months ago 3:49pm 30 July 2024 - πΊπΈUnited States greenskin
Added an issue π Actions broken when using workflow transition form Active with a merge request in Gin's issue queue to ignore the workflow transition form IDs. That issue fixes the general missing actions, while the patch from #2 here resolves the drop button getting hidden behind "More actions".