Contrib.social

Fatal error in Drupal 10.2

Open on Drupal.org →
Created on 1 July 2024, 5 months ago
Updated 4 July 2024, 5 months ago

Problem/Motivation

The Media AVportal module in version 1.7 applies D10.3 only patch for the remote_stream_wrapper module which brings an error in D10.2.

Problematic patch:
"Drupal 10.3.x only - see media_avportal/README.md for 10.2.x - https://www.drupal.org/project/remote_stream_wrapper/issues/3437974 📌 Drupal 10.3 ImageStyleDownloadController::deliver signature change Needs review ": " https://www.drupal.org/files/issues/2024-06-21/drupal_10_3_deliver_signa... → "

Steps to reproduce

Drush cr

Fatal error: Declaration of Drupal\remote_stream_wrapper\Controller\RemoteImageStyleDownloadController::deliver(Symfony\Component\HttpFoundation\Request $request, $scheme, Drupal\image\ImageStyleInterface $image_style, string $required_derivative_scheme) must be compatible with Drupal\image\Controller\ImageStyleDownloadController::deliver(Symfony\Component\HttpFoundation\Request $request, $scheme, Drupal\image\ImageStyleInterface $image_style) in /var/www/html/web/modules/contrib/remote_stream_wrapper/src/Controller/RemoteImageStyleDownloadController.php on line 42

🐛 Bug report
Status

Closed: works as designed

Version

1.7

Component

Code

Created by

🇵🇱Poland piotrsmykaj

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @piotrsmykaj
  • Status changed to Closed: works as designed 5 months ago
  • Comment 5 months ago →
    🇬🇷Greece vensires

    I copy the text from the README.md file of the module:

    ### Usage with Drupal 10.2

For Drupal 10.2, the drupal/remote_stream_wrapper (issue 3437974) patch needs to be removed.
If you require this module in Drupal 10.2 you must unset the patch in your composer.json.\
You can do this with the following command:
```bash
composer config --merge --json "extra.patches-ignore.drupal/media_avportal" '{"drupal/remote_stream_wrapper": {"Drupal 10.3.x only - see media_avportal/README.md for 10.2.x - https://www.drupal.org/project/remote_stream_wrapper/issues/3437974": "https://www.drupal.org/files/issues/2024-06-21/drupal_10_3_deliver_signature_change-3437974-2_0_0-18.patch"}}'
```

    Feel free to reopen the ticket if I didn't correctly understand your issue.

  • Comment 5 months ago →
    🇵🇱Poland piotrsmykaj

    hello @vensires.
    Thank you for the reply as I missed this information in the readme file.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024