Contrib.social

When batch size exceeds 999, assembleRows throws an error

Open on Drupal.org →
Created on 30 June 2024, 5 months ago
Updated 1 July 2024, 5 months ago

Problem/Motivation

When trying to visit the log of a given run of a script, if its more than 999, the batch size is passed to AssembleRows in the OperationPage as a string.

Steps to reproduce

  • Set a batch of 1000 (or more) in your script
  • Run the script
  • Stop the run before completing
  • Go to the Operation list
  • Click on the script with the batch of 1000
  • Experience WSOD

Proposed resolution

Add (int) to pass $batch_size as an int on line 109 of
codit_batch_operations_ui/src/Controller/OperationPage.php

From

    $rows = $this->assembleRows($batch_op_class_name, $batch_size);

to

    $rows = $this->assembleRows($batch_op_class_name, (int)$batch_size);

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States skyriter

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @skyriter
  • Comment 5 months ago →
    🇺🇸United States skyriter
  • Status changed to Postponed 5 months ago
  • Comment 5 months ago →
    🇺🇸United States swirt Florida

    Interesting find. I think we should table this one in favor of 📌 Remove examples and references to getBatchSize() Active
    The batch setting right now is really an illusion and there is no benefit in using it in 99% of the uses cases.

    It is too hard to explain both how to do the remaining 1% and show an example of how to actually try it do anything better than a batch size of 1.

  • Status changed to Fixed 5 months ago
  • Comment 5 months ago →
    🇺🇸United States swirt Florida

    Thank you for finding this @skyriter and reporting it.

    I actually resolved this as part of 📌 Remove examples and references to getBatchSize() Active
    It turned out we were passing a formatted number string so anything under 1000 got interpreted as an int, but then at 1,000 it got a comma added and became a string.
    I altered the code to pass in the raw value and not the formatted value.

  • Status changed to Fixed 5 months ago
  • Comment 5 months ago →
    🇺🇸United States swirt Florida

    Released as 1.0.1-rc2 →

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024