- Issue created by @fgm
- Assigned to sourabhsisodia_
- Merge request !30Issue #3458044: Fix implicitly nullable type declarations. → (Open) created by sourabhsisodia_
- Issue was unassigned.
- Status changed to Needs review
10 months ago 12:14pm 1 July 2024 @fgm Fixed implicitly nullable type declarations in the code , Please review.
- Status changed to Needs work
10 months ago 1:00pm 1 July 2024 - 🇫🇷France fgm Paris, France
@sourabhsisodia_ can you also update the .gitlab-ci.yml to run the checks on PHP 8.4 ?
Also note that this is not just a base module issue, but applies to all the modules in the project. It's just associated to the base module because on d.o. one can only select a single component.
@fgm updated the MR according to recommended changes and also checked other submodules for nullable type declarations.
- 🇫🇷France fgm Paris, France
Thanks. As you can see, this MR fails https://git.drupalcode.org/issue/mongodb-3458044/-/pipelines/213633/test... so you now need to fix it.
@fgm can you please look into the phpunit error , I have tried but not able to solve.