- Issue created by @jimmb
- ๐ฌ๐งUnited Kingdom AdamPS
#1 is probably a bug. It comes from ContactEmailBuilderBase.php line 30 which adds in the mailto: . I don't really know why๐.
#2 should be corrected by "URL to absolute" in your All/All email policy. Maybe you removed it by mistake?
- ๐บ๐ธUnited States jimmb
Thanks very much for the reply. And in light of this, then it looks like there may be 2 bugs ...
For #1, it's good to at least know the likely cause of this. It's obviously not essential, but would be nice someday if this just showed the e-mail address like the default Drupal setup.
For #2, I double checked and 'URL to absolute' is there. I've attached a screenshot from /admin/config/system/mailer, which shows that it's active. As such, I'm guessing that is a bug as well.
Any ideas to troubleshoot this would be much appreciated. And naturally if you can fix either or both of these bugs, that would be fantastic!
- ๐ฌ๐งUnited Kingdom AdamPS
#1 if someone can make a merge request that does what I described in #3 then I will commit it
#2 is working fine for me, so it needs steps to reproduce. If you could try on a clean site the problem might go away.
- ๐ฎ๐ณIndia Prem Suthar gujrat
Prem Suthar โ made their first commit to this issueโs fork.
- Merge request !973457962-senderurl-should-not : Remove the mail to From the sender url. โ (Merged) created by Prem Suthar
- Status changed to Needs review
about 1 month ago 2:15pm 2 August 2024 -
AdamPS โ
committed 22de64a4 on 1.x authored by
Prem Suthar โ
Issue #3457962 by Prem Suthar: sender_url should not contain mailto:
-
AdamPS โ
committed 22de64a4 on 1.x authored by
Prem Suthar โ
- Status changed to Fixed
about 1 month ago 11:09am 4 August 2024 - Status changed to Needs work
25 days ago 11:33am 14 August 2024 - ๐ฌ๐งUnited Kingdom AdamPS
Wait a minute.
The mailto: is there because the variable is supposed to be a URL, which you can put it inside a href. The default policy contains this line, and this patch has broken it.
<a href="{{ sender_url }}">{{ sender_name }}</a> has sent you a message via your form at {{ site_name }}.
Perhaps instead we could make a new variable sender_mail? However in that case it would change behaviour for a registered user, when the URL will be something like
/user/{user}
.Perhaps you can remove the mailto: in twig? See https://stackoverflow.com/questions/15600626/begins-with-in-twig-template.
-
AdamPS โ
committed 0bf397e4 on 1.x
Revert "Issue #3457962 by Prem Suthar: sender_url should not contain...
-
AdamPS โ
committed 0bf397e4 on 1.x