Contrib.social

Toolbar icon not visible in standard install

Open on Drupal.org →
Created on 28 June 2024, 5 months ago

Problem/Motivation

Using the 2.1.6 release, the dashboard link had a visible icon. With 2.1.7 or 2.1.x, the icon is not visible. This seems to have come from the CSS changes in 📌 Improve Gin Admin theme support. Fixed . If the CSS changes are reverted, the icon reappears.

Steps to reproduce

Install Drupal and enable the Dashboards module. Use the out-of-the box admin theme, not Gin.

Proposed resolution

Restore the icon

Remaining tasks

Determine a way to support Gin without breaking other themes.

🐛 Bug report
Status

Needs review

Version

2.1

Component

User interface

Created by

🇨🇦Canada kpaxman

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @kpaxman
  • Merge request !36Only add Gin-specific icon when in Gin → (Open) created by kpaxman
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7
    last update 5 months ago
    Waiting for branch to pass
  • Status changed to Needs review 5 months ago
  • Comment 5 months ago →
    🇨🇦Canada kpaxman

    My MR in theory preserves the fix for Gin without having it break other themes. I did basic testing with Gin and the Gin Toolbar to confirm the icon was still visible there, but I don't know enough about Gin to test more than that.

  • Pipeline finished with Failed
    5 months ago
    Total: 508s
    #211089
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024