- Issue created by @Liam Morland
- Status changed to Needs review
5 months ago 4:48pm 28 June 2024 - 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
This merge request fixes all phpcs issues.
There are still phpstan issues. Some of these can likely be resolved by adding the dependent modules to Composer so that phpstan can find them.
- 🇵🇭Philippines Zed9
I'm still finding cs issues after applying MR https://git.drupalcode.org/project/openai/-/merge_requests/94
FILE: /web/modules/contrib/openai/PATCHES.txt ----------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------- 5 | ERROR | [x] Expected 1 newline at end of file; 3 found ----------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------- FILE: /web/modules/contrib/openai/modules/openai_devel/src/Plugin/DevelGenerate/ContentGPTDevelGenerate.php ------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------- 254 | ERROR | The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /web/modules/contrib/openai/modules/openai_content/openai_content.module -------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------- 217 | ERROR | The array declaration extends to column 95 (the limit is 80). The array content should be split up over multiple lines -------------------------------------------------------------------------------------------------------------------------------------- - Status changed to Needs work
5 months ago 10:34pm 30 June 2024 - Status changed to Needs review
5 months ago 10:35pm 30 June 2024 - First commit to issue fork.
-
scott_euser →
committed 4f4715ed on 1.0.x authored by
Liam Morland →
Issue #3457892 by Liam Morland: Make coding standards fixes
-
scott_euser →
committed 4f4715ed on 1.0.x authored by
Liam Morland →
- Status changed to Fixed
5 months ago 1:46pm 3 July 2024 - 🇬🇧United Kingdom scott_euser
Agreed, fine to cover phpcs and deal with phpstan in a follow-up. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.