- Issue created by @johnlutz
- Merge request !12Add autoconfigure = true because it is needed for the MediaLibraryState to find this resolver. β (Merged) created by johnlutz
- Status changed to Needs review
6 months ago 1:23pm 26 June 2024 - Assigned to mark_fullmer
- πΊπΈUnited States mark_fullmer Tucson
Thanks for the bug report and the proposed change! Assigning myself for review...
- π¨π¦Canada bwaindwain
I've tested mr12 and works great. Thanks @johnlutz! +RTBC
- Status changed to Fixed
6 months ago 3:29pm 27 June 2024 -
mark_fullmer β
committed ea5bff4a on 2.x authored by
johnlutz β
Issue #3457129: RuntimeException: media_library.opener.form_element must...
-
mark_fullmer β
committed ea5bff4a on 2.x authored by
johnlutz β
- πΊπΈUnited States mark_fullmer Tucson
Agreed. This looks good! Merging to the 2.x branch.
- Status changed to Active
6 months ago 8:38pm 27 June 2024 - πΊπΈUnited States mark_fullmer Tucson
Re-opening, since as implied by the original description, this has backwards compatibility consequences: previous versions of media_library_form_element will not work with Drupal core 10.3 or above.
Given this, we should probably change the core_version_requirement to >=10.3 in the 2.x branch and cut a new release sooner rather than later, so that this doesn't prevent sites from updating to Drupal 10.3
I am a maintainer, but do not have permission to create new releases, so another of the maintainers will need to be involved.
Increasing the priority to "Major."
- πΊπΈUnited States mark_fullmer Tucson
Clarification: based on testing, the change introduced here does not introduce BC problems with prior versions of Drupal core. Rather, this change is required for compatibility with Drupal 10.3 and above.
Therefore, I think we just need to cut a new release -- no change to the core_version_requirement.
- πΊπΈUnited States millerrs
Thanks @johnlutz and @mark_fullmer! I encountered this issue after upgrading to 10.3.0, and MR12 worked. A new release would be great to avoid needing a patch or using the dev version.
@nightlife2008, can you help with releasing version 2.1.0?
- πΊπΈUnited States luke.leber Pennsylvania
Hey @millerrs - we're working toward a 2.1.0 release. There's an ongoing discussion right now that has to be resolved first.
- Status changed to Needs work
6 months ago 2:37pm 1 July 2024 - πΊπΈUnited States luke.leber Pennsylvania
Following up here - this is what I get on Drupal 10.1 when attempting to run a
drush cr
on a site with 2.x:www-data@5bae608a62be:~/html$ drush cr In YamlFileLoader.php line 161: The configuration key "autoconfigure" cannot be used to define a default value in "modules/contrib/media_library_form_element/media_library_form_element.services.yml". Allowed keys are "public", "tags", "autowire".
I think we may have to declare ^10.3 only here?
- Status changed to Fixed
6 months ago 2:42pm 1 July 2024 - πΊπΈUnited States luke.leber Pennsylvania
Opened drupal.org/project/media_library_form_element/issues/3457129 as a follow-up; re-closing :-)
Automatically closed - issue fixed for 2 weeks with no activity.