Implementation of Dependency Injection for EbtSettingsDefaultWidget class

Open on Drupal.org →

Created on 25 June 2024, 6 months ago

Updated 26 June 2024, 6 months ago

Problem/Motivation

The EbtSettingsDefaultWidget that extends WidgetBase is working fine however the ide is pointing the \Drupal calls should be avoided in classes and asks to use DI instead

Proposed resolution

Just implement a constructor for class receiving this class as dependency. After that we can replace the \Drupal:: call to use $this-> replacing

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Fixed

Version

1.4

Component

Code

Created by

🇧🇷Brazil renatog Campinas

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!44Implementation of Dependency Injection for EbtSettingsDefaultWidget class
Merged
🇧🇷Brazil renatog
updated 6 months ago

Comments & Activities

Issue created by @renatog
Merge request !44Issue #3457124 by renatog: Implementation of Dependency Injection for... → (Merged) created by renatog
Status changed to Needs review 6 months ago8:29pm 25 June 2024
Comment 6 months ago →
🇧🇷Brazil renatog Campinas
Fixed, MR available at: https://git.drupalcode.org/project/ebt_core/-/merge_requests/44

Comment 6 months ago →

f3377f65 committed on 1.4.x

Issue #3457124 by renatog: Implementation of Dependency Injection for...

Status changed to Fixed 6 months ago12:28pm 26 June 2024
Comment 6 months ago →
🇷🇸Serbia levmyshkin Novi Sad, Serbia
Hi Renato, thank you!
Status changed to Fixed 6 months ago12:31pm 26 June 2024
Comment 6 months ago →
🇷🇸Serbia levmyshkin Novi Sad, Serbia

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024