Rename "watchdog_mailer_enable" config key to "enabled"

Hi @Anybody,

"enabled" key is already present in watchdog_mailer.settings for another field. It is affecting to changing key for 'watchdog_mailer_enable'.
Please suggest on this.

Thanks!

Yes it's already used for the sublevel but should also be used for the top level. Only a complete implementation including correct update hook will be credited.

Thank you @Anybody for reply.

Can you please check 'WatchdogMailerSettingsTest.php'? In this file there are no levels and sublevels, here they maintain sequence only.
So it will be confusing here. Please suggest on this.

I have done with my code just waiting for your reply on this.

Thanks!!

Hi @Anybody,

Please review my changes and let me know your valuable feedback on this.

MR - https://git.drupalcode.org/project/watchdog_mailer/-/merge_requests/23
Commit - https://git.drupalcode.org/project/watchdog_mailer/-/merge_requests/23/d...

Thank you!

Just a last grammatical issue, then this LGTM. @LRwebks can you please fix that and test if it works as expected?

Okay, I noticed that a few instances of watchdog_mailer_enable were still left in the project and then noticed the problem with the rename:
As far as I can see this change might actually interfere with the enabled value from the Notification Object, e.g. ->set('enabled', $form_state->getValue('enabled')) appears twice and as such the submit would not work correctly.
I think we have two options here now: Revert this change or rename the Notification Object key to something like notification_object_enabled.
@Anybody, @supriyak: What do you think of this?

Nice! Technically, they can't interfere, but good finding, the author just missed these other locations! :)

Please also test the update hook using cex before and after!

Unfortunately, after a bit of testing it is clear that the keys do conflict with saving and dynamic visibility. If one enabled</code checkbox is enabled, then both will be saved as enabled. Similarly, the form is only hidden if BOTH checkboxed are turned off, if the <code>watchdog_mailer_enable is off and the Notification Object is still on, the Form is still visible...
How do we solve this now?

Well, now, after a lot of tweaking related to the fact that the different keys were unintentionally pulled to the same level within the form and were now conflicting - everything should be working now! Tests are green locally as well.

Great work! RTBC! :) And a further step into multiple notifications configurations direction :)

Merged!

Automatically closed - issue fixed for 2 weeks with no activity.