Create close button on CMS to be configured by content Editors

Created on 24 June 2024, 10 months ago

Updated 25 June 2024, 10 months ago

Problem/Motivation

On Micromodal there is a open button and close button. The open one is available on CMS so CMS editors can update the label but the close button don't. It's hard-coded, so is possible to translate after 🐛 Make close button translatable for multilingual sites Fixed but would be better if we have this one on CMS to be consistent with "Open" button. Another good reason is that in few cases the button "Close" can be "OK" or "Thanks" for example

Proposed resolution

Create a CMS field for "Close" button and after that update the FE twigs to consider this new field

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request

Status

Fixed

Version

1.4

Component

Code

Created by

🇧🇷Brazil renatog Campinas

Live updates comments and jobs are added and updated live.

Merge Requests

!3Create close button on CMS to be configured by content Editors
Merged
🇧🇷Brazil renatog
updated 10 months ago

Comments & Activities

Issue created by @renatog
Merge request !3Issue #3456876 by renatog: Create close button on CMS to be configured by content Editors → (Merged) created by renatog
Status changed to Needs review 10 months ago10:49pm 24 June 2024
Comment 10 months ago →
🇧🇷Brazil renatog Campinas
Implemented the close button at CMS. MR available at: https://git.drupalcode.org/project/ept_micromodal/-/merge_requests/3

Comment 10 months ago →

System Message

51c65fcc committed on 1.4.x

Issue #3456876 by renatog: Create close button on CMS to be configured...

Comment 10 months ago →
🇷🇸Serbia levmyshkin Novi Sad, Serbia
Hi Renato, thank you!
Status changed to Fixed 10 months ago8:20am 25 June 2024
Comment 10 months ago →
🇷🇸Serbia levmyshkin Novi Sad, Serbia

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024