- Issue created by @Gábor Hojtsy
- 🇭🇺Hungary Gábor Hojtsy Hungary
So the fails are unrelated, but we need to resolve them somewhere anyway. Only these errors are found currently:
<tr class="color-warning"> <td class="status-info">web/modules/contrib/upgrade_status/tests/modules/upgrade_status_test_error/upgrade_status_test_error.routing.yml</td> <td>0</td> <td>The _access_node_revision routing requirement is deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use _entity_access instead. See <a href="https://www.drupal.org/node/3161210">https://www.drupal.org/node/3161210</a>.</td> </tr> <tr class="color-warning"> <td class="status-info">web/modules/contrib/upgrade_status/tests/modules/upgrade_status_test_error/upgrade_status_test_error.css</td> <td>0</td> <td>The #drupal-off-canvas selector is deprecated in drupal:9.5.0 and is removed from drupal:10.0.0. See <a href="https://www.drupal.org/node/3305664">https://www.drupal.org/node/3305664</a>.</td> </tr> <tr class="color-warning"> <td class="status-info">web/modules/contrib/upgrade_status/tests/modules/upgrade_status_test_error/config/views.view.remove_default_argument_skip_url.yml</td> <td>109</td> <td>Support from all Views contextual filter settings for the default_argument_skip_url setting is removed from drupal:11.0.0. No replacement is provided. See <a href="https://www.drupal.org/node/3382316">https://www.drupal.org/node/3382316</a>.</td> </tr> <tr class="color-warning"> <td class="status-info">web/modules/contrib/upgrade_status/tests/modules/upgrade_status_test_error/upgrade_status_test_error.info.yml</td> <td>1</td> <td>Add core_version_requirement to designate which Drupal versions is the extension compatible with. See <a href="https://drupal.org/node/3070687">https://drupal.org/node/3070687</a>.</td> </tr>
- 🇭🇺Hungary Gábor Hojtsy Hungary
These errors are missing. I reproduced this manually too
$file = reset($report['data']['files']); $message = $file['messages'][0]; $this->assertEquals('fatal.php', basename(key($report['data']['files']))); $this->assertEquals("Syntax error, unexpected T_STRING on line 5", $message['message']); $this->assertEquals(5, $message['line']); $file = next($report['data']['files']); $this->assertEquals('UpgradeStatusTestErrorController.php', basename(key($report['data']['files']))); $message = $file['messages'][0]; $this->assertEquals("Call to deprecated function upgrade_status_test_contrib_error_function_9_to_10(). Deprecated in drupal:9.1.0 and is removed from drupal:10.0.0. Use the replacement instead.", $message['message']); $this->assertEquals(13, $message['line']); $file = next($report['data']['files']); $this->assertEquals('ExtendingClass.php', basename(key($report['data']['files']))); $message = $file['messages'][0]; $this->assertEquals("Class Drupal\upgrade_status_test_error\ExtendingClass extends deprecated class Drupal\upgrade_status_test_error\DeprecatedBaseClass. Deprecated in drupal:9.1.0 and is removed from drupal:10.0.0. Instead, use so and so. See https://www.drupal.org/project/upgrade_status.", $message['message']); $this->assertEquals(10, $message['line']); $file = next($report['data']['files']); $this->assertEquals('UpgradeStatusTestErrorEntity.php', basename(key($report['data']['files']))); $message = $file['messages'][0]; $this->assertEquals("Configuration entity must define a `config_export` key. See https://www.drupal.org/node/2481909", $message['message']); $this->assertEquals(15, $message['line']);
- 🇭🇺Hungary Gábor Hojtsy Hungary
So the underlying problem is that PHPStan does not return any files, it returns this error independent on files.
array ( 'totals' => array ( 'errors' => 1, 'file_errors' => 0, ), 'files' => array ( ), 'errors' => array ( 0 => 'Syntax error, unexpected T_STRING on line 5 while analysing file /var/www/html/web/modules/contrib/upgrade_status/tests/modules/contriby/fatal.php', ), )
Parsing this our code figures there were no files whatsoever and no PHPStan output gets into the scan. Question is what happened on the side of PHPStan recently and how we should parse the output now.
- Status changed to Needs review
6 months ago 8:56am 2 July 2024 - 🇭🇺Hungary Gábor Hojtsy Hungary
Span out the underlying PHPStan issue to 📌 PHPStan does not return full results as of 1.11.5 if there was an "internal error" Fixed , resolved that so we can continue here.
-
Gábor Hojtsy →
committed 7edbdabe on 4.x
Issue #3456719 by Gábor Hojtsy: Don't say that Drupal 10.3.0 is not yet...
-
Gábor Hojtsy →
committed 7edbdabe on 4.x
- Status changed to Fixed
6 months ago 9:12am 2 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.