Contrib.social

fixed a wrong validation on breakpoints

Open on Drupal.org →
Created on 23 June 2024, 11 days ago
Updated 24 June 2024, 11 days ago

Problem/Motivation

Currently there is an issue on breakpoints validation. However, all the breakpoints are different:

Breakpoints

  • Mobile breakpoint 640
  • Tablet breakpoint 1020
  • Desktop breakpoint 1320

Width

  • xxSmall width 480
  • xSmall width 640
  • Small width 960
  • Default width 960
  • Large width 1100
  • xLarge width 1320
  • xxLarge width 1600

Steps to reproduce

With EBT core installed, go to settings admin/config/content/ebt-core, without any change click in save. Will appear a validation message: "All the breakpoints must be different".

Proposed resolution

This is happening because the validation is comparing breakpoints with all width values as well

Currently already exists a comparison for breakpoints, that will validate that brakpoints for Desktop, Mobile and Tablet are different.

Breakpoints

  • Mobile
  • Tablet
  • Desktop

Now the other validation should compare specifically for Width

  • xxSmall
  • xSmall
  • Small
  • Default
  • Large
  • xLarge
  • xxLarge

With that I'll works fine. The validation will make sure that there is no duplicated values on breakpoints, and after that will verify if don't have duplicated values on width as well

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.4

Component

Code

Created by

🇧🇷Brazil RenatoG Campinas

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024