Use correct library directory name for local nouislider library in README

Created on 22 June 2024, 6 months ago

Problem/Motivation

The README says:

For Slider functionality if wanting to use internal library place
https://cdnjs.cloudflare.com/ajax/libs/noUiSlider/15.5.1/nouislider.min.js into libraries/noUiSlider

The module uses this code to switch the library. Note that it looks in nouislider directory, not in noUiSlider, since the directory name is case sensitive. If you install the local library according to the instructions, the library will still be loaded from the CDN.

In some jurisdictions, using an external library may violate data protection laws, which may impose significant fines on the site owner.

Steps to reproduce

  1. Install the local library according to the instructions in the README.
  2. Clear all caches.
  3. Verify that the external library is still being used.

Proposed resolution

  1. At a minimum, update the library directory name in the README to match the code.
  2. Optionally: The library is actually available as a Composer package, so we can use Drupal Core's scaffolding plugin and that Composer package to have Composer manage the library for us. I think this is better than downloading the library manually, so I'd propose to recommend that approach to users.

Remaining tasks

  1. Decide on proposed resolution. 1 only or 2 as well?
  2. Test and review.

User interface changes

None.

API changes

None.

Data model changes

None.

πŸ› Bug report
Status

Active

Version

7.0

Component

Documentation

Created by

πŸ‡©πŸ‡ͺGermany FeyP

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024