Implements Dependency Injection instead of Drupal::service at EptSettingsDefaultWidget

Open on Drupal.org →

Created on 22 June 2024, 5 months ago

Problem/Motivation

Currently on EptSettingsDefaultWidget is used Drupal::service to verify if field_group is enabled and with that attach a library of horizontal tabs or not. It works but is a good approach to use dependency injection instead since it makes the code more testable and making the code more modular and easier to maintain

Proposed resolution

Inject the dependency on constructor, implement a create and use the object with $this->

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Fixed

Version

1.4

Component

Code

Created by

🇧🇷Brazil renatog Campinas

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!5Implements Dependency Injection instead of Drupal::service at EptSettingsDefaultWidget
Merged
🇧🇷Brazil renatog
updated 5 months ago

Comments & Activities

Issue created by @renatog
Merge request !5Issue #3418633 by saccard: Ignores customized... → (Merged) created by renatog
Status changed to Needs review 5 months ago2:20am 22 June 2024
Comment 5 months ago →
🇧🇷Brazil renatog Campinas
Implemented at MR: https://git.drupalcode.org/project/ept_core/-/merge_requests/5

Comment 5 months ago →

c04c69c7 committed on 1.4.x

Issue #3456366 by renatog: Implements Dependency Injection instead of...

Comment 5 months ago →
🇷🇸Serbia levmyshkin Novi Sad, Serbia
Hi Renato, thank you!
Comment 5 months ago →
🇷🇸Serbia levmyshkin Novi Sad, Serbia
Status changed to Fixed 5 months ago8:02am 22 June 2024
Comment 5 months ago →
🇷🇸Serbia levmyshkin Novi Sad, Serbia

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024