- Issue created by @hongqing
- Assigned to abhishek_virasat
- Issue was unassigned.
- Status changed to Needs review
5 months ago 5:49am 21 June 2024 - 🇮🇳India abhishek_virasat
@hongqing, I have fixed the issue and created MR , Please review it once.
- Status changed to Needs work
5 months ago 2:45pm 28 June 2024 - 🇺🇸United States agentrickard Georgia (US)
I'd like to see an explicit NULL check rather than the older
if ($domain)
style.is_null or instanceof would both be fine here.
I can't reproduce the problem on a clean install of Drupal 10 and on the dev branch.
Based on the suggested changes, the changes look good, but I'd like to understand how to reproduce the problem. More details needed.- 🇺🇸United States agentrickard Georgia (US)
It may just be an edge case. I don't mind the extra check for instanceOf in that case.
- Status changed to Needs review
5 months ago 2:44pm 1 July 2024 - 🇺🇸United States agentrickard Georgia (US)
I have pushed the minor change to the branch.
-
agentrickard →
committed eb438867 on 2.0.x authored by
abhishek_gupta1 →
Issue #3456056 by abhishek_gupta1, agentrickard, davps: Domain Access:...
-
agentrickard →
committed eb438867 on 2.0.x authored by
abhishek_gupta1 →
- Status changed to Fixed
5 months ago 2:54pm 1 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- 🇨🇳China hongqing
Thank you for quick response. Now I found it may be related to users. This occurs when I login with a role I created, there is no error with admin and authenticated roles.
- 🇨🇳China hongqing
This particularly happens on view with Access permission on domains, never happens on content.