- Issue created by @moshe weitzman
- Merge request !225Allow scheduled pipelines from non 'project' namespace β (Merged) created by moshe weitzman
- πΊπΈUnited States moshe weitzman Boston, MA
The Nightly scheduled pipeline at https://gitlab.com/drupalspoons/devel/-/pipeline_schedules is not running due to this.
- Status changed to Needs work
6 months ago 1:29pm 20 June 2024 - πͺπΈSpain fjgarlin
There is 1 other place where
$CI_PROJECT_ROOT_NAMESPACE == "project"
is present. Should we remove that one too?# Run on commits to the default & release branches. - if: ($CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH || $CI_COMMIT_BRANCH =~ /^[78]\.x-\d+\.x$|^[\d+.]+\.x$/) && $CI_PROJECT_ROOT_NAMESPACE == "project"
- πΊπΈUnited States moshe weitzman Boston, MA
I think that one is OK because $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH will pass.
- πΊπΈUnited States moshe weitzman Boston, MA
I mean, release branches wont get pipelines but thats not such a big deal. Projects that care can override the rules. IMO this can go in as is.
- Status changed to RTBC
6 months ago 2:25pm 20 June 2024 - πͺπΈSpain fjgarlin
Perfect, in that case it looks good to me. RTBC and will merge soon.
-
fjgarlin β
committed 263d991e on main authored by
moshe weitzman β
Issue #3455923 by moshe weitzman, fjgarlin: Allow scheduled pipelines...
-
fjgarlin β
committed 263d991e on main authored by
moshe weitzman β
- Status changed to Fixed
6 months ago 2:56pm 20 June 2024 -
fjgarlin β
committed f96b81e8 on main
Issue #3455923: Changelog for next release.
-
fjgarlin β
committed f96b81e8 on main
- π¬π§United Kingdom jonathan1055
Interestingly, the condition you are removing was actually added in from the original, in this commit from June last year:
https://git.drupalcode.org/project/gitlab_templates/-/commit/65f25ebb - πͺπΈSpain fjgarlin
I think it might have been like that when parts of the templates where shared with core.
Itβs very unlikely that forks will have schedules, so itβs worth loosening that restriction unless proven otherwise, specially if these are not cloned on the forks.
Automatically closed - issue fixed for 2 weeks with no activity.