Contrib.social

Smart Easing Threshold and Smart Easing Amount allows non-numerical values

Open on Drupal.org →
Created on 20 June 2024, 6 months ago
Updated 21 June 2024, 6 months ago

Problem/Motivation

Congrats on very useful project
Looking at https://github.com/levmyshkin/count-up.js?tab=readme-ov-file#options
Saw this information:

  • smartEasingThreshold?: number; // smooth easing for large numbers above this if useEasing (999)
  • smartEasingAmount?: number; // amount to be eased for numbers above threshold (333)

So it should be a number
However CMS editors are able to use non-numerical values on both fields

Steps to reproduce

Create a node
Use Paragraph type of EPT Counter
On settings tab
Go to field Smart Easing Threshold or "Smart Easing Amount"
Remover number and put a text (string)
Save
Result: It's saved without an error
Expected: Since it's a number, only numbers should be allowed

Proposed resolution

We can update the field type to number
It'll fix automatically

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.4

Component

Code

Created by

🇧🇷Brazil renatog Campinas

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024