Decompress files for update_test_new_module

Created on 19 June 2024, 5 months ago
Updated 20 June 2024, 5 months ago

Problem/Motivation

Compressed files, binaries, and databases are difficult to maintain and inspect.

This issue is to address:
./core/modules/update/tests/update_test_new_module/8.x-1.0/update_test_new_module.tar.gz
./core/modules/update/tests/update_test_new_module/8.x-1.1/update_test_new_module.tar.gz
./core/modules/update/tests/update_test_new_module/8.x-1.1/update_test_new_module.zip
./core/modules/update/tests/update_test_new_module/8.x-1.0/update_test_new_module.zip

Background information

This was first reported to the Drupal security team who determined this could be a public followup.

Steps to reproduce

Proposed resolution

Remaining tasks

./core/modules/update/tests/update_test_new_module/8.x-1.0/update_test_new_module.tar.gz
./core/modules/update/tests/update_test_new_module/8.x-1.1/update_test_new_module.tar.gz
./core/modules/update/tests/update_test_new_module/8.x-1.1/update_test_new_module.zip
./core/modules/update/tests/update_test_new_module/8.x-1.0/update_test_new_module.zip

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Active

Version

11.0 🔥

Component
PHPUnit 

Last updated about 2 hours ago

Created by

🇺🇸United States nicxvan

Live updates comments and jobs are added and updated live.
  • Security

    It is used for security vulnerabilities which do not need a security advisory. For example, security issues in projects which do not have security advisory coverage, or forward-porting a change already disclosed in a security advisory. See Drupal’s security advisory policy for details. Be careful publicly disclosing security vulnerabilities! Use the “Report a security vulnerability” link in the project page’s sidebar. See how to report a security issue for details.

Sign in to follow issues

Comments & Activities

  • Issue created by @nicxvan
  • 🇺🇸United States nicxvan
  • 🇺🇸United States nicxvan
  • 🇺🇸United States nicxvan

    The only place the zip is actually referenced is here:

    /**
       * Data provider method for testViaAuthorize().
       *
       * Each of these release URLs has been cached in the setUp() method.
       */
      public static function archiveFileUrlProvider() {
        return [
          'tar.gz' => [
            'url' => 'https://ftp.drupal.org/files/projects/update_test_new_module.tar.gz',
          ],
          'zip' => [
            'url' => 'https://ftp.drupal.org/files/projects/update_test_new_module.zip',
          ],
        ];
      }
    

    I wonder if we can just move these to a contrib module if they are being referenced on d.o anyway.

    The tar is referenced above but also in these two places:

    $validArchiveFile = __DIR__ . '/../../update_test_new_module/8.x-1.0/update_test_new_module.tar.gz';
        $edit = [
          'files[project_upload]' => $validArchiveFile,
        ];
        $this->drupalGet('admin/modules/install');
        $this->submitForm($edit, 'Continue');
    
     <release>
      <name>update_test_new_module 8.x-1.1</name>
      <version>8.x-1.1</version>
      <status>published</status>
      <release_link>http://example.com/update_test_new_module-8-x-1-1-release</release_link>
      <download_link>core/modules/update/tests/update_test_new_module/8.x-1.1/update_test_new_module.tar.gz</download_link>
      <date>1300424521</date>
      <terms>
       <term><name>Release type</name><value>New features</value></term>
       <term><name>Release type</name><value>Bug fixes</value></term>
      </terms>
     </release>
    
  • 🇺🇸United States nicxvan
Production build 0.71.5 2024