- Issue created by @Anybody
- Assigned to jagraj_singh_gill
- Issue was unassigned.
- Status changed to Needs review
6 days ago 11:04am 24 June 2024 - 🇮🇳India jagraj_singh_gill
I think this issue is coming because of this fix : https://www.drupal.org/project/comment_fragment/issues/3455106 🐛 Permalink now points to comment/XYZ/edit Fixed
I think we should revert this fix because I think this module's general purpose is to provide better SEO for comments. So changing the Edit and Delete uri probably may not help us here.
I have placed the MR to revert this fix. Please let me know if you have any other thoughts on same so we can discuss more.Thank You !!
- Status changed to Active
6 days ago 8:14am 25 June 2024 - 🇩🇪Germany Anybody Porta Westfalica
@jagraj_singh_gill that's a funny comment. Let's reintroduce another bug to have this one fixed. How often should we repeat that? ;)
No, this needs a correct fix. But it might not be simple, as this module is some kind of hack into the core structures.
- 🇮🇳India jagraj_singh_gill
@Anybody Thank you for your feedback and sorry if I am not making sense. I understand the importance of addressing this issue with a proper fix thats why I am open to discussion. My point of discussion is that, this module's general purpose is to provide better SEO for comments which involves comment view links. So do we really need to change the Edit and Delete links like we did in the linked issue ? As per my understanding making Edit and Delete links SEO friendly serves no purpose. So I want to know your thoughts on same that how you think of it so that I can learn from it.
- 🇩🇪Germany Anybody Porta Westfalica
@jagraj_singh_gill thanks. No these links were not changed directly or by purpose. It's a bug that they're affected and that should be solved.
I have no idea yet, why they are affected and how to fix that, apparently.